From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Ryan Hope" <rmh3093@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Edward Shishkin" <edward.shishkin@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Reiserfs mailing list" <reiserfs-devel@vger.kernel.org>
Subject: Re: [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync
Date: Tue, 12 Aug 2008 16:00:40 +1000 [thread overview]
Message-ID: <200808121600.40293.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <48f7fe350808112112k5e92330epa8345cbe4eb4c1b5@mail.gmail.com>
On Tuesday 12 August 2008 14:12, Ryan Hope wrote:
> I tried just using __set_page_dirty_nobuffers but that caused issues
> with ext3/ext4 (i can send a bug trace later if needed).
>
> __inc_bdi_stat(mapping->backing_dev_info,
> BDI_RECLAIMABLE);
> task_io_account_write(PAGE_CACHE_SIZE);
>
> ^^^ the above code in __set_page_dirty_nobuffers causes an issue with
> do_writepages in ext3/4 when I use something like the code below:
>
> int reiser4_set_page_dirty_internal(struct page *page)
> {
> return __set_page_dirty_nobuffers(page);
> }
Hmm, it causes issues in ext3/4 even though it doesn't change any
code executed by ext3/4? Yes, if you could send a trace...
next prev parent reply other threads:[~2008-08-12 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 22:40 [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync Ryan Hope
2008-08-12 2:36 ` Nick Piggin
2008-08-12 4:12 ` Ryan Hope
2008-08-12 6:00 ` Nick Piggin [this message]
2008-08-12 14:52 ` Ryan Hope
2008-08-12 12:56 ` Edward Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808121600.40293.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=edward.shishkin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=rmh3093@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox