From: Joerg Roedel <joro@8bytes.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
muli@il.ibm.com
Subject: Re: [PATCH 4/7] x86: add alloc_coherent dma_ops callback to NOMMU driver
Date: Tue, 12 Aug 2008 20:24:56 +0200 [thread overview]
Message-ID: <20080812182455.GD4342@8bytes.org> (raw)
In-Reply-To: <1218554657-16070-5-git-send-email-joerg.roedel@amd.com>
On Tue, Aug 12, 2008 at 05:24:14PM +0200, Joerg Roedel wrote:
> +static void *
> +nommu_alloc_coherent(struct device *hwdev, size_t size,
> + dma_addr_t *dma_addr, gfp_t gfp)
> +{
> + unsigned long dma_mask;
> + int node;
> + struct page *page;
> +
> + if (hwdev->dma_mask == NULL)
> + return NULL;
> +
> + gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
> + gfp |= __GFP_ZERO;
> +
> + dma_mask = hwdev->coherent_dma_mask;
> + if (!dma_mask)
> + dma_mask = *(hwdev->dma_mask);
> +
> + if (dma_mask <= DMA_24BIT_MASK)
> + gfp |= GFP_DMA;
> + else if (dma_mask <= DMA_32BIT_MASK)
> + gfp |= GFP_DMA32;
Argh. But there is a bug in this logic :-(
I fix it and resend.
Joerg
next prev parent reply other threads:[~2008-08-12 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 15:24 [PATCH 0/7] x86 dma_*_coherent rework patchset Joerg Roedel
2008-08-12 15:24 ` [PATCH 1/7] x86: add alloc_coherent dma_ops callback to GART driver Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:46 ` Joerg Roedel
2008-08-13 20:46 ` FUJITA Tomonori
2008-08-12 15:24 ` [PATCH 2/7] x86: add free_coherent " Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:49 ` Joerg Roedel
2008-08-12 15:24 ` [PATCH 3/7] x86: add free_coherent dma_ops callback to Calgary IOMMU driver Joerg Roedel
2008-08-12 16:07 ` Muli Ben-Yehuda
2008-08-12 15:24 ` [PATCH 4/7] x86: add alloc_coherent dma_ops callback to NOMMU driver Joerg Roedel
2008-08-12 18:24 ` Joerg Roedel [this message]
2008-08-12 15:24 ` [PATCH 5/7] x86: add free_coherent " Joerg Roedel
2008-08-12 15:24 ` [PATCH 6/7] x86: cleanup dma_*_coherent functions Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:51 ` Joerg Roedel
2008-08-12 15:24 ` [PATCH 7/7] x86, AMD IOMMU: remove obsolete FIXME comment Joerg Roedel
2008-08-12 16:06 ` [PATCH 0/7] x86 dma_*_coherent rework patchset Muli Ben-Yehuda
2008-08-12 16:49 ` Joerg Roedel
2008-08-13 0:51 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812182455.GD4342@8bytes.org \
--to=joro@8bytes.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=muli@il.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox