From: Dave Jones <davej@redhat.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [WATCHDOG] v2.6.27-rc patches
Date: Tue, 12 Aug 2008 23:10:44 -0400 [thread overview]
Message-ID: <20080813031044.GA11258@redhat.com> (raw)
In-Reply-To: <20080806202918.GA29386@infomag.infomag.iguana.be>
On Wed, Aug 06, 2008 at 10:29:18PM +0200, Wim Van Sebroeck wrote:
> Hi Linus,
>
> Please pull from 'master' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git
> or if master.kernel.org hasn't synced up yet:
> master.kernel.org:/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git
>
> This will update the following files:
>
> Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> Date: Thu Jul 3 23:51:36 2008 -0700
>
> [WATCHDOG] mpc8xxx_wdt: add support for MPC8xx watchdogs
This is broken when built modular because this...
> +}
> +module_init(mpc8xxx_wdt_init_late);
and this ..
> +arch_initcall(mpc8xxx_wdt_init);
Can't be mixed. You end up with two init_module invocations
drivers/watchdog/mpc8xxx_wdt.c:304: error: redefinition of '__inittest'
drivers/watchdog/mpc8xxx_wdt.c:298: error: previous definition of '__inittest' was here
drivers/watchdog/mpc8xxx_wdt.c:304: error: redefinition of 'init_module'
drivers/watchdog/mpc8xxx_wdt.c:298: error: previous definition of 'init_module' was here
Given they both call different routines though, I'm not sure the right fix here.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-08-13 3:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 20:29 [WATCHDOG] v2.6.27-rc patches Wim Van Sebroeck
2008-08-07 7:03 ` Martin Michlmayr
2008-08-07 9:32 ` Ben Dooks
2008-08-07 10:21 ` Wim Van Sebroeck
2008-08-07 8:38 ` Florian Fainelli
2008-08-07 10:24 ` Wim Van Sebroeck
2008-08-13 3:10 ` Dave Jones [this message]
2008-08-13 12:23 ` [PATCH] [WATCHDOG] mpc8xxx_wdt: fix modular build Anton Vorontsov
2008-08-13 14:31 ` Adrian Bunk
2008-08-13 17:21 ` Anton Vorontsov
2008-08-13 18:34 ` [PATCH v2] " Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813031044.GA11258@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox