From: Andrew Morton <akpm@linux-foundation.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Huang Ying <ying.huang@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Machek <pavel@ucw.cz>,
nigel@nigel.suspend2.net, "Rafael J. Wysocki" <rjw@sisk.pl>,
mingo@elte.hu, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH] kexec jump: fix code size checking
Date: Wed, 13 Aug 2008 10:07:03 -0700 [thread overview]
Message-ID: <20080813100703.10f50b40.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080813131927.GB3957@redhat.com>
On Wed, 13 Aug 2008 09:19:27 -0400 Vivek Goyal <vgoyal@redhat.com> wrote:
> On Wed, Aug 13, 2008 at 09:04:35AM +0800, Huang Ying wrote:
> > Fix building issue when CONFIG_KEXEC=n. Thanks to Vivek Goyal for his
> > reminding.
> >
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> >
> > ---
> > include/asm-x86/kexec.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > --- a/include/asm-x86/kexec.h
> > +++ b/include/asm-x86/kexec.h
> > @@ -43,6 +43,9 @@
> >
> > #ifdef CONFIG_X86_32
> > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048
> > +# ifndef CONFIG_KEXEC
> > +# define kexec_control_code_size 0
> > +# endif
> > #endif
> >
> > #ifndef __ASSEMBLY__
>
> I think Andrew already fixed it. Right way is to put code in vmlinux.lds.S
> under #ifdef CONFIG_KEXEC, than defining the symbol kexec_control_code_size
> if CONFIG_KEXEC=n
I was wondering about that.
I resurrected that patch.
prev parent reply other threads:[~2008-08-13 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 1:04 [PATCH] kexec jump: fix code size checking Huang Ying
2008-08-13 2:47 ` Simon Horman
2008-08-13 3:05 ` Huang Ying
2008-08-13 3:40 ` Eric W. Biederman
2008-08-13 5:18 ` Huang Ying
2008-08-13 5:51 ` Simon Horman
2008-08-13 3:48 ` Simon Horman
2008-08-13 13:21 ` Vivek Goyal
2008-08-13 13:19 ` Vivek Goyal
2008-08-13 17:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813100703.10f50b40.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox