From: Joerg Roedel <joro@8bytes.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: Setup code crashes my old 486 box
Date: Wed, 13 Aug 2008 12:40:38 +0200 [thread overview]
Message-ID: <20080813104038.GE4342@8bytes.org> (raw)
In-Reply-To: <20080813100013.GD2214@elte.hu>
On Wed, Aug 13, 2008 at 12:00:13PM +0200, Ingo Molnar wrote:
>
> * Joerg Roedel <joro@8bytes.org> wrote:
>
> > On Tue, Aug 12, 2008 at 03:57:31PM -0700, H. Peter Anvin wrote:
> > > Right in concept, but I dislike the implementation (duplication of the
> > > CPU detect code we already have). Could you try this patch and see if
> > > it works for you?
> >
> > Cool, with a small modification to fix a build error with it the
> > resulting kernel boots my machine. Thanks.
> > Would be cool to have this patch one merged soon :-)
> > Attached is your patch with my little build fix. It redefines a values
> > already defines in cpufeatures.h but I can't include that file in the
> > boot code so I simply redeclared it. Maybe there is a cleaner solution
> > for this.
>
> thanks, i've commited the fix below to tip/x86/urgent - it should show
> up in v2.6.27-rc4 and it might even be backportable to -stable. I've
> added your Signed-off-by - is that ok with you?
Ok, cool. Thats fine for me. Thanks.
Joerg
next prev parent reply other threads:[~2008-08-13 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 22:47 Setup code crashes my old 486 box Joerg Roedel
2008-08-12 22:57 ` H. Peter Anvin
2008-08-12 22:55 ` Alan Cox
2008-08-13 0:21 ` H. Peter Anvin
2008-08-13 8:07 ` Joerg Roedel
2008-08-13 10:00 ` Ingo Molnar
2008-08-13 10:40 ` Joerg Roedel [this message]
2008-08-13 15:33 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813104038.GE4342@8bytes.org \
--to=joro@8bytes.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox