Re: [PATCH] kexec jump: fix code size checking

Andrew Morton
2008-08-13T17:08:30Z

On Wed, 13 Aug 2008 09:19:27 -0400 Vivek Goyal <vgoyal@redhat.com> wrote:

> On Wed, Aug 13, 2008 at 09:04:35AM +0800, Huang Ying wrote:
> > Fix building issue when CONFIG_KEXEC=n. Thanks to Vivek Goyal for his
> > reminding.
> >
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> >
> > ---
> > include/asm-x86/kexec.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > --- a/include/asm-x86/kexec.h
> > +++ b/include/asm-x86/kexec.h
> > @@ -43,6 +43,9 @@
> >
> > #ifdef CONFIG_X86_32
> > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048
> > +# ifndef CONFIG_KEXEC
> > +# define kexec_control_code_size 0
> > +# endif
> > #endif
> >
> > #ifndef __ASSEMBLY__
>
> I think Andrew already fixed it. Right way is to put code in vmlinux.lds.S
> under #ifdef CONFIG_KEXEC, than defining the symbol kexec_control_code_size
> if CONFIG_KEXEC=n

I was wondering about that.

I resurrected that patch.