From: Greg KH <greg@kroah.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Pavel Machek <pavel@suse.cz>,
joachim.deguara@amd.com, gregkh@ucw.cz, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/01][retry 2] x86: L3 cache index disable for 2.6.26
Date: Wed, 13 Aug 2008 16:45:03 -0700 [thread overview]
Message-ID: <20080813234503.GA32154@kroah.com> (raw)
In-Reply-To: <200808131502.42611.mark.langsdorf@amd.com>
On Wed, Aug 13, 2008 at 03:02:42PM -0500, Mark Langsdorf wrote:
> +#if defined(CONFIG_PCI) && defined(CONFIG_K8_NB)
> +#include <linux/pci.h>
Not needed to be hid behind a #if.
> +#include <asm/k8.h>
#includes go at the top of files.
> +static struct pci_dev *get_k8_northbridge(int node)
> +{
> + return k8_northbridges[node];
> +}
> +#else
> +static inline int pci_write_config_dword(struct pci_dev *dev, int where,
> + u32 val)
Don't redefine these common functions, pci.h will handle this properly
if for some reason CONFIG_PCI is not enabled.
thanks,
greg k-h
next prev parent reply other threads:[~2008-08-13 23:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 21:03 [PATCH 01/01] x86: L3 cache index disable for 2.6.26 Mark Langsdorf
2008-07-21 11:37 ` Ingo Molnar
2008-07-21 12:48 ` Ingo Molnar
2008-07-22 18:06 ` Mark Langsdorf
2008-07-28 14:22 ` Ingo Molnar
2008-07-28 14:49 ` Ingo Molnar
2008-07-28 14:54 ` Langsdorf, Mark
2008-08-08 22:00 ` Pavel Machek
2008-08-12 16:04 ` [PATCH 01/01][retry 1] " Mark Langsdorf
2008-08-12 21:56 ` Pavel Machek
2008-08-12 22:01 ` Langsdorf, Mark
2008-08-12 22:07 ` Pavel Machek
2008-08-12 22:53 ` Greg KH
2008-08-12 22:12 ` Greg KH
2008-08-13 20:02 ` [PATCH 01/01][retry 2] " Mark Langsdorf
2008-08-13 20:38 ` Pavel Machek
2008-08-13 23:45 ` Greg KH [this message]
2008-08-14 13:43 ` [PATCH 01/01][retry 3] " Mark Langsdorf
2008-08-14 13:44 ` Pavel Machek
2008-08-14 14:02 ` Langsdorf, Mark
2008-08-14 15:46 ` Pavel Machek
2008-08-14 16:41 ` Langsdorf, Mark
2008-08-14 14:04 ` Greg KH
2008-08-14 14:23 ` [PATCH 01/01][retry 4] " Mark Langsdorf
2008-08-14 16:48 ` [PATCH 01/01][retry 5] " Mark Langsdorf
2008-08-14 17:10 ` Greg KH
2008-08-14 18:32 ` Mark Langsdorf
2008-08-15 16:42 ` Ingo Molnar
2008-08-15 19:21 ` Langsdorf, Mark
2008-08-15 19:57 ` Ingo Molnar
2008-08-15 20:02 ` Langsdorf, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813234503.GA32154@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@ucw.cz \
--cc=hpa@zytor.com \
--cc=joachim.deguara@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@redhat.com \
--cc=pavel@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox