From: Arjan van de Ven <arjan@infradead.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH](retry 3) invalidate caches before going into suspend
Date: Thu, 14 Aug 2008 07:00:55 -0700 [thread overview]
Message-ID: <20080814070055.0a47393d@infradead.org> (raw)
In-Reply-To: <200808140845.05160.mark.langsdorf@amd.com>
On Thu, 14 Aug 2008 08:45:04 -0500
Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> When a CPU core is shut down, all of its caches need to be flushed
> to prevent stale data from causing errors if the core is resumed.
> Current Linux suspend code performs an assignment after the flush,
> which can add dirty data back to the cache. On some AMD platforms,
> additional speculative reads have caused crashes on resume because
> of this dirty data.
>
> Relocate the cache flush to be the very last thing done before
> halting. Tie into an assembly line so the compile will not
> reorder it. Add some documentation explaining what is going
> on and why we're doing this.
looks good to me
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-08-14 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 16:41 invalidate caches before going into suspend Mark Langsdorf
2008-08-13 16:47 ` Ingo Molnar
2008-08-13 16:53 ` H. Peter Anvin
2008-08-13 17:01 ` Ingo Molnar
2008-08-13 17:28 ` H. Peter Anvin
2008-08-13 17:35 ` Ingo Molnar
2008-08-13 17:37 ` H. Peter Anvin
2008-08-13 17:09 ` Mark Langsdorf
2008-08-13 17:17 ` Linus Torvalds
2008-08-13 17:30 ` Mark Langsdorf
2008-08-13 17:52 ` Ingo Molnar
2008-08-13 18:33 ` [PATCH](retry 2) " Mark Langsdorf
2008-08-13 18:42 ` Arjan van de Ven
2008-08-13 18:47 ` Langsdorf, Mark
2008-08-13 21:32 ` Arjan van de Ven
2008-08-14 13:45 ` [PATCH](retry 3) " Mark Langsdorf
2008-08-14 13:49 ` Ingo Molnar
2008-08-14 14:00 ` Arjan van de Ven [this message]
2008-08-14 14:11 ` [PATCH](retry 4) " Mark Langsdorf
2008-08-15 12:04 ` Ingo Molnar
2008-08-13 17:38 ` Ingo Molnar
2008-08-13 19:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814070055.0a47393d@infradead.org \
--to=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox