public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: crane cai <crane.cai@amd.com>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] HPET: Workaround for a BIOS workaround on AMD SB700 platform
Date: Thu, 14 Aug 2008 11:04:40 +0200	[thread overview]
Message-ID: <20080814090440.GF1650@elte.hu> (raw)
In-Reply-To: <1218683616.20466.13.camel@crane-laptop>


small build fix:

>From c107f81791afa9f749cf242944c90a18faf69fda Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 14 Aug 2008 11:03:24 +0200
Subject: [PATCH] x86, hpet: workaround for a BIOS workaround on AMD SB700 platform, fix

fix:

 arch/x86/kernel/early-quirks.c: In function 'amd_sb700_hpet':
 arch/x86/kernel/early-quirks.c:105: error: 'sb700_hpet_workaround' undeclared (first use in this function)
 arch/x86/kernel/early-quirks.c:105: error: (Each undeclared identifier is reported only once
 arch/x86/kernel/early-quirks.c:105: error: for each function it appears in.)

which triggers in the !HPET + !HPET_TIMER case.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-x86/hpet.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/hpet.h b/include/asm-x86/hpet.h
index 8f9a4e2..261fb68 100644
--- a/include/asm-x86/hpet.h
+++ b/include/asm-x86/hpet.h
@@ -55,8 +55,6 @@
  */
 #define HPET_MIN_PERIOD		100000UL
 
-extern int sb700_hpet_workaround;
-
 /* hpet memory map physical address */
 extern unsigned long hpet_address;
 extern unsigned long force_hpet_address;
@@ -87,6 +85,8 @@ extern void hpet_unregister_irq_handler(rtc_irq_handler handler);
 
 #else /* CONFIG_HPET_TIMER */
 
+extern int sb700_hpet_workaround;
+
 static inline int hpet_enable(void) { return 0; }
 static inline int is_hpet_enabled(void) { return 0; }
 #define hpet_readl(a) 0


  parent reply	other threads:[~2008-08-14  9:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14  3:13 [PATCH] HPET: Workaround for a BIOS workaround on AMD SB700 platform crane cai
2008-08-14  8:41 ` Ingo Molnar
2008-08-14  9:10   ` crane cai
2008-08-14  9:04 ` Ingo Molnar [this message]
2008-08-14 10:11 ` Thomas Gleixner
2008-08-15  2:09   ` crane cai
2008-08-15 12:27     ` Ingo Molnar
2008-08-14 14:11 ` Lennart Sorensen
2008-08-14 14:14   ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080814090440.GF1650@elte.hu \
    --to=mingo@elte.hu \
    --cc=crane.cai@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox