public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH](retry 3) invalidate caches before going into suspend
Date: Thu, 14 Aug 2008 15:49:51 +0200	[thread overview]
Message-ID: <20080814134951.GA14333@elte.hu> (raw)
In-Reply-To: <200808140845.05160.mark.langsdorf@amd.com>


* Mark Langsdorf <mark.langsdorf@amd.com> wrote:

> + * Systems without cache can just go into halt.
> + */
> +static void wbinvd_halt(void) {

please put this into a unified include file, and as an inline - there's 
just a single callsite. That avoids duplication and also removes a 
function.

Also, please run the patch through scripts/checkpatch, it would have 
suggested to change this:

> +static void wbinvd_halt(void) {

to:

> +static void wbinvd_halt(void)
> +{

Thanks,

	Ingo

  reply	other threads:[~2008-08-14 13:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 16:41 invalidate caches before going into suspend Mark Langsdorf
2008-08-13 16:47 ` Ingo Molnar
2008-08-13 16:53   ` H. Peter Anvin
2008-08-13 17:01     ` Ingo Molnar
2008-08-13 17:28       ` H. Peter Anvin
2008-08-13 17:35         ` Ingo Molnar
2008-08-13 17:37           ` H. Peter Anvin
2008-08-13 17:09   ` Mark Langsdorf
2008-08-13 17:17     ` Linus Torvalds
2008-08-13 17:30       ` Mark Langsdorf
2008-08-13 17:52         ` Ingo Molnar
2008-08-13 18:33           ` [PATCH](retry 2) " Mark Langsdorf
2008-08-13 18:42             ` Arjan van de Ven
2008-08-13 18:47               ` Langsdorf, Mark
2008-08-13 21:32                 ` Arjan van de Ven
2008-08-14 13:45                   ` [PATCH](retry 3) " Mark Langsdorf
2008-08-14 13:49                     ` Ingo Molnar [this message]
2008-08-14 14:00                     ` Arjan van de Ven
2008-08-14 14:11                     ` [PATCH](retry 4) " Mark Langsdorf
2008-08-15 12:04                       ` Ingo Molnar
2008-08-13 17:38     ` Ingo Molnar
2008-08-13 19:39 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080814134951.GA14333@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox