From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758699AbYHNVTX (ORCPT ); Thu, 14 Aug 2008 17:19:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753618AbYHNVTO (ORCPT ); Thu, 14 Aug 2008 17:19:14 -0400 Received: from one.firstfloor.org ([213.235.205.2]:38759 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbYHNVTN (ORCPT ); Thu, 14 Aug 2008 17:19:13 -0400 Date: Thu, 14 Aug 2008 23:20:36 +0200 From: Andi Kleen To: Mathieu Desnoyers Cc: Ingo Molnar , Jeremy Fitzhardinge , Harvey Harrison , Andi Kleen , Linus Torvalds , Steven Rostedt , Steven Rostedt , LKML , Thomas Gleixner , Peter Zijlstra , Andrew Morton , David Miller , Roland McGrath , Ulrich Drepper , Rusty Russell , Gregory Haskins , Arnaldo Carvalho de Melo , "Luis Claudio R. Goncalves" , Clark Williams , Christoph Lameter , "H. Peter Anvin" Subject: Re: [PATCH] x86 alternatives : fix LOCK_PREFIX race with preemptible kernel and CPU hotplug Message-ID: <20080814212036.GD13814@one.firstfloor.org> References: <20080814205815.GA14076@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080814205815.GA14076@Krystal> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So, unless these calculus are completely bogus, the difference between the nop > and the DS case seems not to be statistically significant. My understanding was that the nops only make a measurable difference in the -pg/mcount/ftrace patched out case where every function call starts with a 5 byte nop. Presumably function calls are much more common than lock prefix operations. -Andi