From: Rusty Russell <rusty@rustcorp.com.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Roland McGrath <roland@redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>,
Bruce Duncan <bwduncan@gmail.com>,
Marcin Slusarz <marcin.slusarz@gmail.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH v2 3/6] ftrace: enable mcount recording for modules
Date: Fri, 15 Aug 2008 09:26:07 +1000 [thread overview]
Message-ID: <200808150926.08200.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080814194859.811269740@goodmis.org>
On Friday 15 August 2008 05:45:09 Steven Rostedt wrote:
> This patch enables the loading of the __mcount_section of modules and
> changing all the callers of mcount into nops.
...
> + if (mcountindex) {
> + void *mseg = (void *)sechdrs[mcountindex].sh_addr;
> + ftrace_init_module(mseg, mseg + sechdrs[mcountindex].sh_size);
You don't actually need the if. The size of section 0 is 0.
Rusty.
next prev parent reply other threads:[~2008-08-14 23:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 19:45 [PATCH v2 0/6] ftrace: to kill a daemon (small updates) Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 1/6] ftrace: create __mcount_loc section Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 2/6] ftrace: mcount call site on boot nops core Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 3/6] ftrace: enable mcount recording for modules Steven Rostedt
2008-08-14 23:26 ` Rusty Russell [this message]
2008-08-14 23:40 ` Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 4/6] ftrace: rebuild everything on change to FTRACE_MCOUNT_RECORD Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 5/6] ftrace: enable using mcount recording on x86 Steven Rostedt
2008-08-14 19:45 ` [PATCH v2 6/6] ftrace: x86 mcount stub Steven Rostedt
2008-08-15 9:24 ` [PATCH v2 0/6] ftrace: to kill a daemon (small updates) Ingo Molnar
2008-08-15 11:22 ` Gregory Haskins
2008-08-15 12:36 ` Marcin Slusarz
2008-08-15 12:50 ` Steven Rostedt
2008-08-15 13:35 ` Marcin Slusarz
2008-08-20 19:28 ` Marcin Slusarz
2008-08-20 19:36 ` Steven Rostedt
2008-08-21 12:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808150926.08200.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bwduncan@gmail.com \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=ghaskins@novell.com \
--cc=jeremy@goop.org \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox