From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>,
srostedt@redhat.com
Subject: Re: [PATCH 0/3] ftrace: handle kernel code remove
Date: Fri, 15 Aug 2008 11:28:44 +0200 [thread overview]
Message-ID: <20080815092844.GD22209@elte.hu> (raw)
In-Reply-To: <20080815024716.480118113@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> The dynamic ftrace feature keeps a table of all the places that call
> mcount to either disable them (replacing them with nops) or to enable
> them (calling some trace function).
>
> This table of functions is also displayed to the user interface to let
> users enable or disable specific functions. This allows users to only
> trace some functions within the kernel.
>
> When a module or init sections are removed, the pointers to their
> locations still exist in this table. To protect against faults and
> writing over other text, fault handling and code comparing is done.
> When the code is update, the code being replaced is calculated and
> compared to the actual text that is being replaced, if the code does
> not match what is expected to be there, the change is not made.
>
> There is a very small chance that the wrong text (or perhaps a data
> section) could match the call to mcount and an inappropriate
> modification could be made.
>
> This patch series adds ftrace_release, to allow a module to remove the
> pointers to the mcount callers in the module from this table.
>
> Also, __init has "notrace" added to it so that text in the init
> section are not traced. The trace currently can not be enabled until
> after init anyway, so this should not be a problem.
applied to tip/tracing/ftrace - thanks Steve! I merged it into
tip/master and started testing it.
Ingo
next prev parent reply other threads:[~2008-08-15 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 2:47 [PATCH 0/3] ftrace: handle kernel code remove Steven Rostedt
2008-08-15 2:47 ` [PATCH 1/3] ftrace: do not show freed records in available_filter_functions Steven Rostedt
2008-08-15 2:47 ` [PATCH 2/3] ftrace: move notrace to compiler.h Steven Rostedt
2008-08-15 2:47 ` [PATCH 3/3] ftrace: remove old pointers to mcount Steven Rostedt
2008-08-15 9:28 ` Ingo Molnar [this message]
2008-08-15 9:38 ` [PATCH 0/3] ftrace: handle kernel code remove Ingo Molnar
2008-08-15 9:48 ` Ingo Molnar
2008-08-15 10:06 ` Ingo Molnar
2008-08-15 10:14 ` Ingo Molnar
2008-08-15 20:02 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815092844.GD22209@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ghaskins@novell.com \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox