From: Rusty Russell <rusty@rustcorp.com.au>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: "Jens Axboe" <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org,
"吉川 拓哉" <yoshikawa.takuya@oss.ntt.co.jp>,
dpshah@google.com
Subject: Re: request->ioprio
Date: Sat, 16 Aug 2008 17:13:36 +1000 [thread overview]
Message-ID: <200808161713.37146.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1218779462.5291.59.camel@sebastian.kern.oss.ntt.co.jp>
On Friday 15 August 2008 15:51:02 Fernando Luis Vázquez Cao wrote:
> On Thu, 2008-08-14 at 12:16 +1000, Rusty Russell wrote:
> > On Wednesday 13 August 2008 17:06:03 Fernando Luis Vázquez Cao wrote:
> > > Besides, I guess that accessing the io context information (such as
> > > ioprio) of a request through elevator-specific private structures is
> > > not something we want virtio_blk (or future users) to do.
> >
> > The only semantic I assumed was "higher is better". The server (ie.
> > host) can really only use the information to schedule between I/Os for
> > that particular guest anyway.
>
> Does that mean you are not going to incorporate the prio class system
> that is used in Linux?
Actually, since it's unused at the moment, we can define it however we want.
But note that this is an ABI; while the kernel-internal definitions are
fluid, this semantic must stay the same (even if the actual values differ).
So we should probably put an explicit mapping function there anyway.
Thanks,
Rusty.
next prev parent reply other threads:[~2008-08-16 7:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1218014196.4419.44.camel@sebastian.kern.oss.ntt.co.jp>
2008-08-06 20:33 ` request->ioprio Rusty Russell
2008-08-13 7:06 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-13 8:14 ` [PATCH] virtio_blk: use a wrapper function to access io context information of IO requests Fernando Luis Vázquez Cao
2008-08-14 4:42 ` Rusty Russell
2008-08-14 5:17 ` Fernando Luis Vázquez Cao
2008-08-14 5:22 ` Fernando Luis Vázquez Cao
2008-08-14 7:58 ` Jens Axboe
2008-08-14 2:16 ` request->ioprio Rusty Russell
2008-08-14 4:26 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-15 5:51 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-16 7:13 ` Rusty Russell [this message]
2008-08-06 9:32 request->ioprio Fernando Luis Vázquez Cao
2008-08-06 17:22 ` request->ioprio Divyesh Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808161713.37146.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dpshah@google.com \
--cc=fernando@oss.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox