From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Parag Warudkar <parag.warudkar@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Add Dell laptop driver
Date: Sun, 17 Aug 2008 00:23:36 +0100 [thread overview]
Message-ID: <20080816232336.GA6992@srcf.ucam.org> (raw)
In-Reply-To: <82e4877d0808161617k5404f4ectf6d502de5b7fea4c@mail.gmail.com>
On Sat, Aug 16, 2008 at 07:17:05PM -0400, Parag Warudkar wrote:
> > + da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> > + sizeof(struct calling_interface_token),
> > + GFP_KERNEL);
>
> Isn't a NULL check required here?
To the extent that it would result in this failing gracefully before
some other part of the kernel becomes hideously upset, sure. I have a
hard time caring, but I can easily fix it if other people do :)
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-08-16 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 23:17 [PATCH 2/2] Add Dell laptop driver Parag Warudkar
2008-08-16 23:23 ` Matthew Garrett [this message]
2008-08-16 23:31 ` Parag Warudkar
-- strict thread matches above, loose matches on Subject: below --
2008-08-16 20:24 [PATCH 0/2] " Matthew Garrett
2008-08-16 20:26 ` [PATCH 1/2] Export SMI call functionality from dcdbas driver Matthew Garrett
2008-08-16 20:30 ` [PATCH 2/2] Add Dell laptop driver Matthew Garrett
2008-08-16 20:47 ` Arjan van de Ven
2008-08-16 20:51 ` Matthew Garrett
2008-08-20 6:46 ` Andrew Morton
2008-08-20 10:21 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080816232336.GA6992@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox