From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: adobriyan@gmail.com, jirislaby@gmail.com,
akpm@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] De-macro spin_trylock_irq, spin_trylock_irqsave, write_trylock_irqsave
Date: Sun, 17 Aug 2008 00:52:55 -0700 (PDT) [thread overview]
Message-ID: <20080817.005255.28108612.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.1.10.0808161417400.3324@nehalem.linux-foundation.org>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 16 Aug 2008 14:21:41 -0700 (PDT)
>
>
> On Sun, 17 Aug 2008, Alexey Dobriyan wrote:
>
> > On Sat, Aug 16, 2008 at 03:31:00PM +0200, Jiri Slaby wrote:
> > >
> > > Doesn't this break on sparc -- is it tested there?
> >
> > What's so special about sparc?
>
> Sparc _used_ to save/restore the whole processor flags word with the irq
> flags. That includes, iirc, things like the register window crap, so if
> you did a save/restore flags in a function, it would get all that wrong
> and things would blow up.
>
> However, I don't think sparc has actually done that for a _loong_ time
> now, due to it always being problematic.
We fixed it.
Although I still sometimes consider saving and restoring cpu IRQ flags
in different function contexts to be on the ugly side :)
next prev parent reply other threads:[~2008-08-17 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 9:59 [PATCH] De-macro spin_trylock_irq, spin_trylock_irqsave, write_trylock_irqsave Alexey Dobriyan
2008-08-16 13:31 ` Jiri Slaby
2008-08-16 20:48 ` Alexey Dobriyan
2008-08-16 21:21 ` Linus Torvalds
2008-08-17 7:52 ` David Miller [this message]
2008-08-16 13:46 ` Ingo Molnar
2008-08-16 21:04 ` Alexey Dobriyan
2008-08-16 21:18 ` Johannes Weiner
2008-08-17 9:31 ` Ingo Molnar
2008-08-17 12:30 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817.005255.28108612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox