From: Sam Ravnborg <sam@ravnborg.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jeff Mahoney <jeffm@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix creation of include2/asm symlink
Date: Sun, 17 Aug 2008 20:37:14 +0200 [thread overview]
Message-ID: <20080817183714.GA18976@uranus.ravnborg.org> (raw)
In-Reply-To: <s5hskt5nxfs.wl%tiwai@suse.de>
On Sat, Aug 16, 2008 at 11:03:51AM +0200, Takashi Iwai wrote:
> At Fri, 15 Aug 2008 21:49:54 +0200,
> Sam Ravnborg wrote:
> >
> > On Fri, Aug 15, 2008 at 03:45:58PM +0200, Takashi Iwai wrote:
> > > The directory include2/asm can point wrongly to a non-existing
> > > directory on architectures that have moved include/asm under arch/*.
> > >
> > > This patch fixes it by checking firstly whether arch/*/include/asm is
> > > available.
> >
> > Hi Takashi.
> >
> > I understand why you try to avoid include2/asm as it is not pretty.
> > And I had a similar patch once - but I dropped it as the symlink do
> > not harm and it will anyway be gone when the remaining architectures
> > has shifted to use arch/$ARCH/include/...
> >
> > So I will not apply it.
>
> Hm, OK. Originally I fixed it because our build system has a sanity
> check against bogus symlinks and refused to package the latest kernel.
> If you don't want to put it in, we can keep it locally, of course.
> But, a bogus symlink is definitely not pretty...
It will go away as soon as all architextures are moved to use arch/$ARCH/include
Sam
next prev parent reply other threads:[~2008-08-17 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 13:45 [PATCH] kbuild: Fix creation of include2/asm symlink Takashi Iwai
2008-08-15 19:49 ` Sam Ravnborg
2008-08-16 9:03 ` Takashi Iwai
2008-08-17 18:37 ` Sam Ravnborg [this message]
2008-08-18 5:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817183714.GA18976@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox