From: Andrew Morton <akpm@linux-foundation.org>
To: Andreas Mohr <andi@lisas.de>
Cc: linux@dominikbrodowski.net, andi@lisas.de,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
johnstul@us.ibm.com, hirofumi@mail.parknet.co.jp,
alan@lxorguk.ukuu.org.uk, arjan@infradead.org
Subject: Re: [PATCH 2/2] acpi_pm.c: check for monotonicity
Date: Mon, 18 Aug 2008 13:28:58 -0700 [thread overview]
Message-ID: <20080818132858.b844a1d4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080818201844.GA3506@rhlx01.hs-esslingen.de>
On Mon, 18 Aug 2008 22:18:44 +0200
Andreas Mohr <andi@lisas.de> wrote:
> Hi,
>
> On Mon, Aug 18, 2008 at 10:11:15PM +0200, Dominik Brodowski wrote:
> > + if (good != 10) {
> > + printk(KERN_INFO "PM-Timer had no reasonable result:"
> > + " 0x%#llx - aborting.\n", value1);
> > + return -ENODEV;
> > }
> > - printk(KERN_INFO "PM-Timer had no reasonable result:"
> > - " 0x%#llx - aborting.\n", value1);
> > - return -ENODEV;
>
> Technically spoken this log message could now be considered partially
> outdated... (we're doing 10 evaluations after all, not one with a
> precise end result).
>
>
> Seeing a define for those several open-coded 10 loops values would be nice.
>
Also it's a bit dodgy printing a cycle_t with %llx. We don't _know_
that cycle_t was implemented with `long long' - if this was always
true, we wouldn't (or shouldn't) have a cycle_t at all.
But it seems that it happens to work for all architectures which
implement acpi.
next prev parent reply other threads:[~2008-08-18 20:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 10:17 ACPI PM-Timer on K6-3 SiS5591: Houston Andreas Mohr
2008-08-10 16:29 ` Dominik Brodowski
2008-08-10 16:40 ` Arjan van de Ven
2008-08-10 19:08 ` Andreas Mohr
2008-08-10 20:02 ` Dominik Brodowski
2008-08-18 19:03 ` [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ACPI PM-Timer on K6-3 SiS5591: Houston...] Dominik Brodowski
2008-08-18 19:05 ` [PATCH 1/2] acpi_pm.c: use proper read function also in errata mode Dominik Brodowski
2008-08-18 19:05 ` [PATCH 2/2] acpi_pm.c: check for monotonicity Dominik Brodowski
2008-08-18 19:19 ` [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ACPI PM-Timer on K6-3 SiS5591: Houston...] Andrew Morton
2008-08-18 19:35 ` Dominik Brodowski
2008-08-18 19:47 ` Andrew Morton
2008-08-18 20:09 ` Dominik Brodowski
2008-08-18 20:10 ` [PATCH 1/2] acpi_pm.c: use proper read function also in errata mode Dominik Brodowski
2008-08-19 9:43 ` Andrew Morton
2008-08-19 9:49 ` Dominik Brodowski
2008-08-19 9:59 ` Andrew Morton
2008-08-22 22:22 ` [PATCH v2 " Dominik Brodowski
2008-08-22 22:26 ` [PATCH v2 2/2] acpi_pm.c: check for monotonicity Dominik Brodowski
2008-08-23 8:48 ` Jochen Voß
2008-08-18 20:11 ` [PATCH " Dominik Brodowski
2008-08-18 20:18 ` Andreas Mohr
2008-08-18 20:28 ` Andrew Morton [this message]
2008-08-18 20:42 ` Dominik Brodowski
2008-08-18 20:25 ` [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ACPI PM-Timer on K6-3 SiS5591: Houston...] Andrew Morton
2008-08-18 20:29 ` Dominik Brodowski
2008-08-18 20:00 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818132858.b844a1d4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@lisas.de \
--cc=arjan@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=johnstul@us.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox