public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: hannes@saeurebad.de, mingo@elte.hu, npiggin@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alloc_bootmem_core: fix misaligned allocation of 1G page
Date: Mon, 18 Aug 2008 14:17:18 -0700	[thread overview]
Message-ID: <20080818141718.bec87aa6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080813193158.GB5985@alberich.amd.com>

On Wed, 13 Aug 2008 21:31:58 +0200
Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> > Attached is a version that should be easier to read.  Please
> > double-check.
> 
> Nice.
> That's the preferred solution and should replace my initial fix.
> 
> Reviewed-and-tested-by: Andreas Herrmann <andreas.herrmann3@amd.com>

Johannes, I'm unsure whether that patch was the final version.  Could
you please resend it (or its successor)?

With a more complete changelog, please.  This:

    bootmem: fix aligning of node-relative indexes and offsets

doesn't explain what needed fixing, nor how it was fixed, nor the
consequences of leaving it unfixed, etc.

Thanks.

  parent reply	other threads:[~2008-08-18 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12  9:53 [PATCH] alloc_bootmem_core: fix misaligned allocation of 1G page Andreas Herrmann
2008-08-12 16:58 ` Johannes Weiner
2008-08-13 16:41   ` Andreas Herrmann
2008-08-13 18:18     ` Johannes Weiner
2008-08-13 19:31       ` Andreas Herrmann
2008-08-14  0:18         ` [PATCH -v2] bootmem: fix aligning of node-relative indexes and offsets Johannes Weiner
2008-08-18 21:17         ` Andrew Morton [this message]
2008-08-18 21:21           ` [PATCH] alloc_bootmem_core: fix misaligned allocation of 1G page Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080818141718.bec87aa6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=hannes@saeurebad.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox