* Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' [not found] <48A976E6.40906@citrix.com> @ 2008-08-18 21:38 ` Jeremy Fitzhardinge 2008-08-19 1:19 ` Ingo Molnar 2008-08-19 1:36 ` Yinghai Lu 0 siblings, 2 replies; 5+ messages in thread From: Jeremy Fitzhardinge @ 2008-08-18 21:38 UTC (permalink / raw) To: Alex Nixon Cc: Ingo Molnar, the arch/x86 maintainers, Linux Kernel Mailing List Alex Nixon wrote: > From: Alex Nixon <alex.nixon@citrix.com> > Date: Mon, 18 Aug 2008 12:56:48 +0100 > Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' > > Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq. > > This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64. > Thanks Alex. Ingo, please apply. Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > Signed-off-by: Alex Nixon <alex.nixon@citrix.com> > --- > arch/x86/xen/irq.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c > index 28b85ab..bb04260 100644 > --- a/arch/x86/xen/irq.c > +++ b/arch/x86/xen/irq.c > @@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void) > > static void __init __xen_init_IRQ(void) > { > -#ifdef CONFIG_X86_64 > int i; > > /* Create identity vector->irq map */ > @@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void) > for_each_possible_cpu(cpu) > per_cpu(vector_irq, cpu)[i] = i; > } > -#endif /* CONFIG_X86_64 */ > > xen_init_IRQ(); > } > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' 2008-08-18 21:38 ` [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' Jeremy Fitzhardinge @ 2008-08-19 1:19 ` Ingo Molnar 2008-08-19 1:33 ` Yinghai Lu 2008-08-19 1:36 ` Yinghai Lu 1 sibling, 1 reply; 5+ messages in thread From: Ingo Molnar @ 2008-08-19 1:19 UTC (permalink / raw) To: Jeremy Fitzhardinge Cc: Alex Nixon, the arch/x86 maintainers, Linux Kernel Mailing List * Jeremy Fitzhardinge <jeremy@goop.org> wrote: > Alex Nixon wrote: > > From: Alex Nixon <alex.nixon@citrix.com> > > Date: Mon, 18 Aug 2008 12:56:48 +0100 > > Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' > > > > Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq. > > > > This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64. > > > > Thanks Alex. > > Ingo, please apply. > > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> i didnt get the original patches (they arent on lkml) - could you please resend them with your Acked-by line added as well? by the looks of it, both are needed for v2.6.27, agreed? Ingo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' 2008-08-19 1:19 ` Ingo Molnar @ 2008-08-19 1:33 ` Yinghai Lu 0 siblings, 0 replies; 5+ messages in thread From: Yinghai Lu @ 2008-08-19 1:33 UTC (permalink / raw) To: Ingo Molnar Cc: Jeremy Fitzhardinge, Alex Nixon, the arch/x86 maintainers, Linux Kernel Mailing List On Mon, Aug 18, 2008 at 6:19 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Jeremy Fitzhardinge <jeremy@goop.org> wrote: > >> Alex Nixon wrote: >> > From: Alex Nixon <alex.nixon@citrix.com> >> > Date: Mon, 18 Aug 2008 12:56:48 +0100 >> > Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' >> > >> > Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq. >> > >> > This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64. >> > >> >> Thanks Alex. >> >> Ingo, please apply. >> >> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > i didnt get the original patches (they arent on lkml) - could you please > resend them with your Acked-by line added as well? > > by the looks of it, both are needed for v2.6.27, agreed? > no, only tip/irq/sparseirq make 32 bit support per_cpu vector. YH ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' 2008-08-18 21:38 ` [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' Jeremy Fitzhardinge 2008-08-19 1:19 ` Ingo Molnar @ 2008-08-19 1:36 ` Yinghai Lu 2008-08-19 19:22 ` Alok Kataria 1 sibling, 1 reply; 5+ messages in thread From: Yinghai Lu @ 2008-08-19 1:36 UTC (permalink / raw) To: Jeremy Fitzhardinge, Rusty Russell, Alok Kataria Cc: Alex Nixon, Ingo Molnar, the arch/x86 maintainers, Linux Kernel Mailing List On Mon, Aug 18, 2008 at 2:38 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote: > Alex Nixon wrote: >> From: Alex Nixon <alex.nixon@citrix.com> >> Date: Mon, 18 Aug 2008 12:56:48 +0100 >> Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' >> >> Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq. >> >> This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64. >> > > Thanks Alex. > > Ingo, please apply. > > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > >> Signed-off-by: Alex Nixon <alex.nixon@citrix.com> >> --- >> arch/x86/xen/irq.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c >> index 28b85ab..bb04260 100644 >> --- a/arch/x86/xen/irq.c >> +++ b/arch/x86/xen/irq.c >> @@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void) >> >> static void __init __xen_init_IRQ(void) >> { >> -#ifdef CONFIG_X86_64 >> int i; >> >> /* Create identity vector->irq map */ >> @@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void) >> for_each_possible_cpu(cpu) >> per_cpu(vector_irq, cpu)[i] = i; >> } >> -#endif /* CONFIG_X86_64 */ >> >> xen_init_IRQ(); >> } >> Rusty, can you check tip/master with lguest? wonder you need to do sth for lguest too. we are making 32 bit support per_cpu vector like 64 bit also alok, can you check vmi etc... Thanks Yinghai Lu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' 2008-08-19 1:36 ` Yinghai Lu @ 2008-08-19 19:22 ` Alok Kataria 0 siblings, 0 replies; 5+ messages in thread From: Alok Kataria @ 2008-08-19 19:22 UTC (permalink / raw) To: Yinghai Lu, Zachary Amsden Cc: Jeremy Fitzhardinge, Rusty Russell, Alex Nixon, Ingo Molnar, the arch/x86 maintainers, Linux Kernel Mailing List On Mon, 2008-08-18 at 18:36 -0700, Yinghai Lu wrote: > On Mon, Aug 18, 2008 at 2:38 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote: > > Alex Nixon wrote: > >> From: Alex Nixon <alex.nixon@citrix.com> > >> Date: Mon, 18 Aug 2008 12:56:48 +0100 > >> Subject: [PATCH] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' > >> > >> Following commit 9c3f2468d8339866d9ef6a25aae31a8909c6be0d, do_IRQ() looks up the IRQ number in the per-cpu variable vector_irq. > >> > >> This commit makes Xen initialise an identity vector_irq map for both X86_32 and X86_64. > >> > > > > Thanks Alex. > > > > Ingo, please apply. > > > > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > > >> Signed-off-by: Alex Nixon <alex.nixon@citrix.com> > >> --- > >> arch/x86/xen/irq.c | 2 -- > >> 1 files changed, 0 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c > >> index 28b85ab..bb04260 100644 > >> --- a/arch/x86/xen/irq.c > >> +++ b/arch/x86/xen/irq.c > >> @@ -21,7 +21,6 @@ void xen_force_evtchn_callback(void) > >> > >> static void __init __xen_init_IRQ(void) > >> { > >> -#ifdef CONFIG_X86_64 > >> int i; > >> > >> /* Create identity vector->irq map */ > >> @@ -31,7 +30,6 @@ static void __init __xen_init_IRQ(void) > >> for_each_possible_cpu(cpu) > >> per_cpu(vector_irq, cpu)[i] = i; > >> } > >> -#endif /* CONFIG_X86_64 */ > >> > >> xen_init_IRQ(); > >> } > >> > > > Rusty, > can you check tip/master with lguest? wonder you need to do sth for lguest too. > we are making 32 bit support per_cpu vector like 64 bit > > also alok, can you check vmi etc... Yes it crashes VMI too, i will get down to debug this maybe later in the day. Thanks YH, for bringing this to my attention. Alok. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-08-19 19:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <48A976E6.40906@citrix.com>
2008-08-18 21:38 ` [PATCH 1/2] Xen: Fix bug `do_IRQ: cannot handle IRQ -1 vector 0x6 cpu 1' Jeremy Fitzhardinge
2008-08-19 1:19 ` Ingo Molnar
2008-08-19 1:33 ` Yinghai Lu
2008-08-19 1:36 ` Yinghai Lu
2008-08-19 19:22 ` Alok Kataria
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox