public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] KVM_GUEST: use the right parameter type on kvm_release_pt() (was Re: i386 allmodconfig in linux-next)
Date: Tue, 19 Aug 2008 16:16:07 -0300	[thread overview]
Message-ID: <20080819191607.GQ6342@blackpad> (raw)
In-Reply-To: <48AACD95.8050207@qumranet.com>

On Tue, Aug 19, 2008 at 04:41:41PM +0300, Avi Kivity wrote:
> Andrew Morton wrote:
>> arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
>> arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type
>>   
>
> Eduardo, this is your
>
>> commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba
>> Author: Eduardo Habkost <ehabkost@redhat.com>
>> Date:   Wed Jul 30 18:32:27 2008 -0300
>>
>>     x86, paravirt_ops: use unsigned long instead of u32 for alloc_p*()  
>> pfn args
>
> Please compile-test (and run-test?) paravirt_ops changes with  
> CONFIG_KVM_GUEST and CONFIG_KVM_CLOCK enabled.  Thanks.
>

Oops, sorry. I've grepped for 'alloc_p*' and didn't notice KVM was using
release_p*. I've checked for binary code changes with all paravirt guest
options enabled, but missed the compiler warnings. Fix below.

---
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH] KVM_GUEST: Use the right parameter type on kvm_release_pt()

This fixes the following compiler warnings, that were introduced by me
on commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba.

arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 arch/x86/kernel/kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 8b7a3cf..478bca9 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -178,7 +178,7 @@ static void kvm_flush_tlb(void)
 	kvm_deferred_mmu_op(&ftlb, sizeof ftlb);
 }
 
-static void kvm_release_pt(u32 pfn)
+static void kvm_release_pt(unsigned long pfn)
 {
 	struct kvm_mmu_op_release_pt rpt = {
 		.header.op = KVM_MMU_OP_RELEASE_PT,
-- 
1.5.5.GIT

-- 
Eduardo

       reply	other threads:[~2008-08-19 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080819024549.5f2c43cf.akpm@linux-foundation.org>
     [not found] ` <48AACD95.8050207@qumranet.com>
2008-08-19 19:16   ` Eduardo Habkost [this message]
2008-08-21 13:50     ` [PATCH] KVM_GUEST: use the right parameter type on kvm_release_pt() (was Re: i386 allmodconfig in linux-next) Avi Kivity
2008-08-22  3:36       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819191607.GQ6342@blackpad \
    --to=ehabkost@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=avi@qumranet.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox