From: Andrew Morton <akpm@linux-foundation.org>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Jaya Kumar <jayakumar.lkml@gmail.com>,
Nick Piggin <npiggin@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Hugh Dickins <hugh@veritas.com>,
Johannes Weiner <hannes@saeurebad.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Kel Modderman <kel@otaku42.de>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB
Date: Wed, 20 Aug 2008 01:37:36 -0700 [thread overview]
Message-ID: <20080820013736.ec64baae.akpm@linux-foundation.org> (raw)
In-Reply-To: <1219220003.3996.29.camel@localhost.localdomain>
On Wed, 20 Aug 2008 09:13:23 +0100 Ian Campbell <ijc@hellion.org.uk> wrote:
> Perhaps applying the band-aid at open time instead would be preferred?
That would be less racy, I expect. Implement fb_ops.fb_open() within
drivers/video/fb_defio.c and do the address_space_operations overwrite
there. Hopefully that will ensure that the address_space_operations
instance is stable before anyone uses it for anything serious.
It'd be better to hook in at inode creation time but afaict that's not
available for the /dev/fb0 node.
<tries to write a patch>
OK, seems that fb_ops.fb_open() has no way of getting at the `struct
file *' which is being opened (wtf?). Screwed. Need to change
fb_ops.fb_open(), or add a new fb_ops.fb_open_sane().
next prev parent reply other threads:[~2008-08-20 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 6:02 [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB Ian Campbell
2008-08-19 6:38 ` Andrew Morton
2008-08-19 7:13 ` Peter Zijlstra
2008-08-20 8:13 ` Ian Campbell
2008-08-20 8:37 ` Andrew Morton [this message]
2008-08-20 18:57 ` Ian Campbell
2008-08-20 19:30 ` Andrew Morton
2008-08-20 19:40 ` Ian Campbell
2008-08-20 19:50 ` Andrew Morton
2008-08-20 23:11 ` Jaya Kumar
2008-08-20 8:46 ` Jaya Kumar
2008-08-20 12:27 ` Markus Armbruster
2008-08-20 18:47 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820013736.ec64baae.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=armbru@redhat.com \
--cc=hannes@saeurebad.de \
--cc=hugh@veritas.com \
--cc=ijc@hellion.org.uk \
--cc=jayakumar.lkml@gmail.com \
--cc=jeremy@goop.org \
--cc=kel@otaku42.de \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox