From: Bart Trojanowski <bart@jukie.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: vfat BKL/lock_super regression in v2.6.26-rc3-g8f59342
Date: Tue, 19 Aug 2008 22:27:12 -0400 [thread overview]
Message-ID: <20080820022712.GF28029@jukie.net> (raw)
In-Reply-To: <alpine.LFD.1.10.0808191748040.3324@nehalem.linux-foundation.org>
* Linus Torvalds <torvalds@linux-foundation.org> [080819 20:56]:
> So one thing we could perhaps consider is to make FAT in particular
> consider "sync" mounts to be about open/close consistency, not about
> per-write-system-call consistency. So the "close()" wouldn't return until
> the file is on disk, but we wouldn't force a synchronous rewrite the inode
> or the file allocation table thousands of times just because the file was
> big.
I was reading the vfat code, and it turns out that vfat has a "flush"
mount option. Which is documented in the code (not in the manpage) as:
struct fat_mount_options {
...
unsigned
...
flush:1, /* write things quickly */
Since that was very informative I looked at the usage. It's used
in fat_file_release() to do almost what you describe. But it seems to
be a best effort thing. If my data doesn't hit the disk (or flash) in
HZ/10, then all bets are off.
-Bart
--
WebSig: http://www.jukie.net/~bart/sig/
next prev parent reply other threads:[~2008-08-20 2:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 22:03 vfat BKL/lock_super regression in v2.6.26-rc3-g8f59342 Bart Trojanowski
2008-08-19 22:06 ` [PATCH] make lock_super recursive to simulate BKL Bart Trojanowski
2008-08-19 22:21 ` Linus Torvalds
2008-08-20 1:14 ` Bart Trojanowski
2008-08-19 22:17 ` vfat BKL/lock_super regression in v2.6.26-rc3-g8f59342 Linus Torvalds
2008-08-20 0:03 ` Bart Trojanowski
2008-08-20 0:11 ` Linus Torvalds
2008-08-20 0:24 ` Bart Trojanowski
2008-08-20 0:18 ` Bart Trojanowski
2008-08-20 0:43 ` Linus Torvalds
2008-08-20 0:56 ` Linus Torvalds
2008-08-20 2:27 ` Bart Trojanowski [this message]
2008-08-20 21:23 ` Diego Calleja
2008-08-23 0:54 ` [PATCH] document additional vfat mount options Bart Trojanowski
2008-08-23 2:33 ` Grant Coady
2008-08-23 3:12 ` Bart Trojanowski
2008-08-23 3:14 ` Bart Trojanowski
2008-08-23 3:27 ` OGAWA Hirofumi
2008-08-23 13:11 ` Bart Trojanowski
2008-08-23 14:47 ` OGAWA Hirofumi
2008-08-23 3:10 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820022712.GF28029@jukie.net \
--to=bart@jukie.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox