From: David Brownell <david-b@pacbell.net>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make gpiochip label const
Date: Wed, 20 Aug 2008 08:50:41 -0700 [thread overview]
Message-ID: <200808200850.41758.david-b@pacbell.net> (raw)
In-Reply-To: <20080820083943.GA24244@doriath.ww600.siemens.net>
On Wednesday 20 August 2008, Dmitry Baryshkov wrote:
> > I don't recall seeing such warnings and I cannot make them happen with
> > drivers/gpio/gpiolib.c or with drivers/gpio/max732x.c or with
> > drivers/gpio/pca953x.c. So we still don't know what this patch
> > does :(
>
> Because both mentioned drivers set gpiochip->label to non-const string.
> You can check arch/arm/common/scoop.c for example of driver showing
> different behaviour:
You're doing it wrong -- in a small way, not a big one. Instead of
devptr->gpio.label = dev_name(&pdev->dev);
do
devptr->gpio.label = "scoop";
devptr->gpio.dev = &pdev->dev;
No warnings generated that way, and another field is set up...
- Dave
prev parent reply other threads:[~2008-08-20 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 20:39 [PATCH] Make gpiochip label const Dmitry Baryshkov
2008-08-12 22:06 ` David Brownell
2008-08-17 19:00 ` Dmitry Baryshkov
2008-08-19 8:43 ` Andrew Morton
2008-08-19 11:13 ` Dmitry
2008-08-19 18:28 ` Andrew Morton
2008-08-20 8:39 ` Dmitry Baryshkov
2008-08-20 15:50 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808200850.41758.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox