From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
muli@il.ibm.com
Subject: Re: [PATCH 0/8] x86 dma_*_coherent rework patchset v2
Date: Wed, 20 Aug 2008 11:46:12 +0200 [thread overview]
Message-ID: <20080820094612.GA28492@elte.hu> (raw)
In-Reply-To: <1219156366-32498-1-git-send-email-joerg.roedel@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> Hi,
>
> this patchset reworks the dma_*_coherent functions in the DMA layer
> for the x86 architecture. The patch series extends the existing DMA
> backends with missing *coherent callbacks and simplifies the generic
> function to basically only call the registered backend. This allows
> future optimizations in hardware specific IOMMU implementations. The
> code ist tested on AMD64 with AMD IOMMU, GART, SWIOTLB and NOMMU as
> well as on my old 486 box. Muli tested the Calgary specific patch.
>
> Joerg
>
> Changes since v1:
>
> - fixed wrong logic in the pci-nommu alloc_coherent code
> - moved dma_*_coherent to include/asm-x86/dma-mapping.h
>
> git diff --stat tip/master.. :
>
> arch/x86/kernel/amd_iommu.c | 2 -
> arch/x86/kernel/pci-calgary_64.c | 14 ++++
> arch/x86/kernel/pci-dma.c | 146 +-------------------------------------
> arch/x86/kernel/pci-gart_64.c | 35 +++++++++-
> arch/x86/kernel/pci-nommu.c | 62 ++++++++++++++++
> include/asm-x86/dma-mapping.h | 47 ++++++++++---
> 6 files changed, 149 insertions(+), 157 deletions(-)
applied to tip/x86/iommu - thanks Joerg!
Jesse, Fujita-san, do these changes look fine to you?
Ingo
next prev parent reply other threads:[~2008-08-20 9:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 14:32 [PATCH 0/8] x86 dma_*_coherent rework patchset v2 Joerg Roedel
2008-08-19 14:32 ` [PATCH 1/8] x86: add alloc_coherent dma_ops callback to GART driver Joerg Roedel
2008-08-21 14:16 ` FUJITA Tomonori
2008-08-21 15:17 ` Joerg Roedel
2008-08-21 17:28 ` [PATCH] x86: make gart_alloc_coherent return zeroed memory Joerg Roedel
2008-08-21 23:19 ` FUJITA Tomonori
2008-08-22 6:35 ` Joerg Roedel
2008-08-22 6:41 ` Ingo Molnar
2008-08-22 6:55 ` Joerg Roedel
2008-08-22 6:36 ` Ingo Molnar
2008-08-19 14:32 ` [PATCH 2/8] x86: add free_coherent dma_ops callback to GART driver Joerg Roedel
2008-08-19 14:32 ` [PATCH 3/8] x86: add free_coherent dma_ops callback to Calgary IOMMU driver Joerg Roedel
2008-08-19 14:32 ` [PATCH 4/8] x86: add alloc_coherent dma_ops callback to NOMMU driver Joerg Roedel
2008-08-19 14:32 ` [PATCH 5/8] x86: add free_coherent " Joerg Roedel
2008-08-19 14:32 ` [PATCH 6/8] x86: cleanup dma_*_coherent functions Joerg Roedel
2008-08-19 14:32 ` [PATCH 7/8] x86: move dma_*_coherent functions to include file Joerg Roedel
2008-08-19 14:32 ` [PATCH 8/8] x86, AMD IOMMU: remove obsolete FIXME comment Joerg Roedel
2008-08-20 9:46 ` Ingo Molnar [this message]
2008-08-20 10:18 ` [PATCH] dma-coherent: export dma_[alloc|release]_from_coherent methods Ingo Molnar
2008-08-20 11:28 ` Joerg Roedel
2008-08-20 17:39 ` [PATCH 0/8] x86 dma_*_coherent rework patchset v2 Jesse Barnes
2008-08-21 12:00 ` Ingo Molnar
2008-08-21 14:16 ` FUJITA Tomonori
2008-08-21 15:07 ` Jesse Barnes
2008-08-22 7:09 ` Ingo Molnar
2008-08-21 15:20 ` Joerg Roedel
2008-08-21 14:16 ` FUJITA Tomonori
2008-08-21 15:12 ` FUJITA Tomonori
2008-08-22 6:44 ` Ingo Molnar
2008-08-22 6:57 ` FUJITA Tomonori
2008-08-22 7:04 ` Ingo Molnar
2008-08-22 7:29 ` FUJITA Tomonori
2008-08-22 8:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820094612.GA28492@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=muli@il.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox