From: Ingo Molnar <mingo@elte.hu>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 09/10] PPS: low level IRQ timestamps recording.
Date: Wed, 20 Aug 2008 12:31:15 +0200 [thread overview]
Message-ID: <20080820103115.GA3912@elte.hu> (raw)
In-Reply-To: <1219182612-13814-10-git-send-email-giometti@linux.it>
* Rodolfo Giometti <giometti@linux.it> wrote:
> Add low level IRQ timestamps recording for x86 (32 and 64 bits)
> platforms and enable UART clients in order to use it.
>
> This improves PPS precision. :)
>
> Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> ---
> arch/x86/kernel/irq_32.c | 18 ++++++++++++++++++
> arch/x86/kernel/irq_64.c | 22 ++++++++++++++++++++--
> drivers/pps/Kconfig | 12 ++++++++++++
> drivers/pps/clients/pps-ldisc.c | 18 ++++++++++++++++++
> include/linux/pps.h | 1 +
> 5 files changed, 69 insertions(+), 2 deletions(-)
hm, NACK on this line of approach. If then this instrumentation should
be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly
- please hide them in include files.
Ingo
next prev parent reply other threads:[~2008-08-20 10:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 21:50 LinuxPPS (RESUBMIT 6): the PPS Linux implementation Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 01/10] LinuxPPS core support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 02/10] PPS: userland header file for PPS API Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 03/10] PPS: documentation programs and examples Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 04/10] PPS: LinuxPPS clients support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 07/10] tty: new PPS line discipline Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 08/10] PPS: serial clients support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 09/10] PPS: low level IRQ timestamps recording Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 10/10] PPS: parallel port clients support Rodolfo Giometti
2008-08-20 10:31 ` Ingo Molnar [this message]
2008-08-19 21:56 ` [PATCH 08/10] PPS: serial " Alan Cox
2008-08-19 21:54 ` [PATCH 07/10] tty: new PPS line discipline Alan Cox
2008-08-19 21:58 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Alan Cox
2008-08-19 21:53 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Alan Cox
2008-08-19 22:49 ` Rodolfo Giometti
2008-08-19 22:38 ` Alan Cox
2008-08-19 23:05 ` Rodolfo Giometti
2008-08-20 8:53 ` Rodolfo Giometti
2008-08-20 10:11 ` Alan Cox
2008-08-20 13:01 ` Rodolfo Giometti
2008-08-20 13:48 ` Ingo Molnar
2008-08-20 14:05 ` Rodolfo Giometti
2008-08-19 23:22 ` [PATCH 01/10] LinuxPPS core support H. Peter Anvin
2008-08-20 9:13 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820103115.GA3912@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=giometti@linux.it \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox