From: Robin Holt <holt@sgi.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
tokunaga.keiich@jp.fujitsu.com
Subject: Re: [RFC][PATCH 0/2] Quicklist is slighly problematic.
Date: Wed, 20 Aug 2008 21:13:32 -0500 [thread overview]
Message-ID: <20080821021332.GA23397@sgi.com> (raw)
In-Reply-To: <48AC25E7.4090005@linux-foundation.org>
On Wed, Aug 20, 2008 at 09:10:47AM -0500, Christoph Lameter wrote:
> KOSAKI Motohiro wrote:
> > Hi Cristoph,
> >
> > Thank you for explain your quicklist plan at OLS.
> >
> > So, I made summary to issue of quicklist.
> > if you have a bit time, Could you please read this mail and patches?
> > And, if possible, Could you please tell me your feeling?
>
> I believe what I said at the OLS was that quicklists are fundamentally crappy
> and should be replaced by something that works (Guess that is what you meant
> by "plan"?). Quicklists were generalized from the IA64 arch code.
>
> Good fixup but I would think that some more radical rework is needed.
>
> Maybe some of this needs to vanish into the TLB handling logic?
>
> Then I have thought for awhile that the main reason that quicklists exist are
> the performance problems in the page allocator. If you can make the single
> page alloc / free pass competitive in performance with quicklists then we
> could get rid of all uses.
It is more than the free/alloc cycle, the quicklist saves us from
having to zero the page. In a sparsely filled page table, it saves time
and cache footprint. In a heavily used page table, you end up with a
near wash.
One problem I see is somebody got rid of the node awareness. We used
to not put pages onto a quicklist when they were being released from a
different node than the cpu is on. Not sure where that went. It was
done because of the trap page problem described here.
Thanks,
Robin
next prev parent reply other threads:[~2008-08-21 2:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 11:05 [RFC][PATCH 0/2] Quicklist is slighly problematic KOSAKI Motohiro
2008-08-20 11:07 ` [RFC][PATCH 1/2] Show quicklist at meminfo KOSAKI Motohiro
2008-08-20 18:35 ` Andrew Morton
2008-08-21 7:36 ` KOSAKI Motohiro
2008-08-22 1:05 ` KOSAKI Motohiro
2008-08-22 4:28 ` Andrew Morton
2008-08-22 13:23 ` Robin Holt
2008-08-22 13:56 ` Christoph Lameter
2008-08-23 8:24 ` KOSAKI Motohiro
2008-08-24 5:29 ` Andrew Morton
2008-08-20 11:08 ` [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs KOSAKI Motohiro
2008-08-20 15:27 ` Christoph Lameter
2008-08-21 6:46 ` Andrew Morton
2008-08-21 7:13 ` David Miller
2008-08-21 7:18 ` KOSAKI Motohiro
2008-08-21 7:27 ` Andrew Morton
2008-08-21 7:31 ` KOSAKI Motohiro
2008-08-21 9:32 ` Peter Zijlstra
2008-08-21 10:04 ` KOSAKI Motohiro
2008-08-21 10:09 ` David Miller
2008-08-21 10:13 ` KOSAKI Motohiro
2008-08-21 10:26 ` David Miller
2008-08-21 10:22 ` KOSAKI Motohiro
2008-08-21 12:02 ` KOSAKI Motohiro
2008-08-25 18:48 ` Mike Travis
2008-08-25 23:33 ` KOSAKI Motohiro
2008-08-26 20:35 ` Mike Travis
2008-08-25 18:44 ` Mike Travis
2008-08-25 18:40 ` Mike Travis
2008-08-25 23:31 ` KOSAKI Motohiro
2008-08-20 14:10 ` [RFC][PATCH 0/2] Quicklist is slighly problematic Christoph Lameter
2008-08-20 14:49 ` KOSAKI Motohiro
2008-08-20 15:26 ` Christoph Lameter
2008-08-21 2:13 ` Robin Holt [this message]
2008-08-21 2:16 ` Robin Holt
2008-08-21 3:08 ` David Miller
2008-08-21 13:10 ` Christoph Lameter
2008-08-20 18:31 ` Andrew Morton
2008-08-21 2:42 ` Robin Holt
2008-08-21 13:07 ` Christoph Lameter
2008-08-21 13:14 ` Robin Holt
2008-08-21 13:18 ` Christoph Lameter
2008-08-21 13:45 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821021332.GA23397@sgi.com \
--to=holt@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tokunaga.keiich@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox