public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <gcosta@redhat.com>
Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [GIT PULL] time.c - respin
Date: Thu, 21 Aug 2008 12:22:22 +0200	[thread overview]
Message-ID: <20080821102222.GA31922@elte.hu> (raw)
In-Reply-To: <200808201507.m7KF79Fk021224@int-mx1.corp.redhat.com>


* Glauber Costa <gcosta@redhat.com> wrote:

> Ingo, please pull the latest master git tree from:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/glommer/linux-2.6-x86-integration.git master
> 
> into your tree. It solves a bisectability issue, but I can't, 
> unfortunately, reproduce the problem you report. So hopefuly you'll 
> now be able to bisect your problems to a point we can find out what's 
> going on

i've tried it, and -tip testing found a hang on 64-bit x86.

It hangs here:

[    0.340029] calling  tc_filter_init+0x0/0x4c
[    0.340029] initcall tc_filter_init+0x0/0x4c returned 0 after 0 msecs
[    0.340029] calling  genl_init+0x0/0xd8
[ hard hang ]

it should have continued with:

[    2.976346] initcall genl_init+0x0/0xd8 returned 0 after 15 msecs
[    2.982303] calling  cipso_v4_init+0x0/0x88
[ ... etc ... ]

i've bisected the hang back to:

0de577d0dd2d1101431d3438d0880fa32a6188d6 is first bad commit
commit 0de577d0dd2d1101431d3438d0880fa32a6188d6
Author: Glauber Costa <gcosta@redhat.com>
Date:   Fri Jul 11 15:43:19 2008 -0300

    x86: use generic intr_init call

    Replace apic initialization code with generic intr_init_hook().

    Signed-off-by: Glauber Costa <gcosta@redhat.com>

the config is at:

 http://redhat.com/~mingo/misc/config-Thu_Aug_21_11_14_36_CEST_2008.bad

but the bug is rather obvious:

-       apic_intr_init();
-
-       if (!acpi_ioapic)
-               setup_irq(2, &irq2);
+       intr_init_hook();

why exactly did you remove the cascade IRQ registration? If it remains 
unallocated and a driver happens to use it funny things might occur.

Also, the commit log does not declare why it's removed.

	Ingo

  reply	other threads:[~2008-08-21 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 15:07 [GIT PULL] time.c - respin Glauber Costa
2008-08-21 10:22 ` Ingo Molnar [this message]
2008-08-21 13:07   ` Glauber Costa
2008-08-24 12:31     ` Ingo Molnar
2008-08-24 13:16       ` Ingo Molnar
2008-08-24 13:39         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821102222.GA31922@elte.hu \
    --to=mingo@elte.hu \
    --cc=gcosta@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox