From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Gregory Haskins <ghaskins@novell.com>, vatsa <vatsa@in.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: properly account IRQ and RT load in SCHED_OTHER load balancing
Date: Thu, 21 Aug 2008 12:47:18 +0200 [thread overview]
Message-ID: <20080821104718.GA28331@elte.hu> (raw)
In-Reply-To: <1219310330.8651.93.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> Subject: sched: properly account IRQ and RT load in SCHED_OTHER load balancing
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Thu Aug 14 09:31:20 CEST 2008
>
> We used to account for RT tasks in SCHED_OTHER load-balancing by giving
> them some phantom weight.
>
> This is incorrect because there is no saying how much time a RT task
> will actually consume. Also, it doesn't take IRQ time into account.
>
> This patch tries to solve this issue by accounting the time spend on
> both Real-Time tasks and IRQ handling, and using that to
> proportionally inflate the SCHED_OTHER load.
applied it to tip/sched/devel for more testing.
this bit:
> +void sched_irq_enter(void)
> +{
> + if (!in_irq()) {
> + struct rq *rq = this_rq();
> +
> + update_rq_clock(rq);
> + rq->irq_stamp = rq->clock;
> + }
if we do this we might as well use the opportunity to do accurate IRQ
(and softirq) CPU time accounting. I.e. right now it only drives
balancing, but isnt fed into the wider IRQ/softirq /proc usage stats.
Ingo
next prev parent reply other threads:[~2008-08-21 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 9:18 [PATCH] sched: properly account IRQ and RT load in SCHED_OTHER load balancing Peter Zijlstra
2008-08-21 10:47 ` Ingo Molnar [this message]
2008-08-21 11:17 ` Ingo Molnar
2008-08-21 11:22 ` Peter Zijlstra
2008-08-21 11:40 ` Ingo Molnar
2008-08-21 11:36 ` Gregory Haskins
2008-08-21 11:41 ` Ingo Molnar
2008-08-21 12:26 ` Gregory Haskins
2008-08-21 12:43 ` Peter Zijlstra
2008-08-21 12:47 ` Gregory Haskins
2008-08-21 12:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821104718.GA28331@elte.hu \
--to=mingo@elte.hu \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox