Re: [PATCH 0/8] x86 dma_*_coherent rework patchset v2

[Joerg Roedel <joerg.roedel@amd.com>]

On Thu, Aug 21, 2008 at 11:16:50PM +0900, FUJITA Tomonori wrote:
> On Thu, 21 Aug 2008 14:00:11 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
> 
> > 
> > * Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> > > On Wednesday, August 20, 2008 2:46 am Ingo Molnar wrote:
> > > > * Joerg Roedel <joerg.roedel@amd.com> wrote:
> > > > > Hi,
> > > > >
> > > > > this patchset reworks the dma_*_coherent functions in the DMA layer
> > > > > for the x86 architecture. The patch series extends the existing DMA
> > > > > backends with missing *coherent callbacks and simplifies the generic
> > > > > function to basically only call the registered backend. This allows
> > > > > future optimizations in hardware specific IOMMU implementations. The
> > > > > code ist tested on AMD64 with AMD IOMMU, GART, SWIOTLB and NOMMU as
> > > > > well as on my old 486 box. Muli tested the Calgary specific patch.
> > > > >
> > > > > Joerg
> > > > >
> > > > > Changes since v1:
> > > > >
> > > > > - fixed wrong logic in the pci-nommu alloc_coherent code
> > > > > - moved dma_*_coherent to include/asm-x86/dma-mapping.h
> > > > >
> > > > > git diff --stat tip/master.. :
> > > > >
> > > > >  arch/x86/kernel/amd_iommu.c      |    2 -
> > > > >  arch/x86/kernel/pci-calgary_64.c |   14 ++++
> > > > >  arch/x86/kernel/pci-dma.c        |  146
> > > > > +------------------------------------- arch/x86/kernel/pci-gart_64.c    |
> > > > >   35 +++++++++-
> > > > >  arch/x86/kernel/pci-nommu.c      |   62 ++++++++++++++++
> > > > >  include/asm-x86/dma-mapping.h    |   47 ++++++++++---
> > > > >  6 files changed, 149 insertions(+), 157 deletions(-)
> > > >
> > > > applied to tip/x86/iommu - thanks Joerg!
> > > >
> > > > Jesse, Fujita-san, do these changes look fine to you?
> > > 
> > > Yeah, I'll let you push this time. :)
> > > 
> > > Signed-off-by:  Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > with a v2.6.28 ETA, right?
> 
> Surely, this patchset should be for 2.6.28.
> 
> Can you send this via the x86 tree instead of pci?
> 
> - IOMMU code is arch stuff rather than pci.
> - We can avoid a mistake such as the previous one.

Yes, this is definitly 2.6.28 stuff.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy