From: Greg KH <gregkh@suse.de>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] driver model: anti-oopsing medicine
Date: Thu, 21 Aug 2008 13:04:41 -0700 [thread overview]
Message-ID: <20080821200441.GA18318@suse.de> (raw)
In-Reply-To: <200808211124.22485.david-b@pacbell.net>
On Thu, Aug 21, 2008 at 11:24:22AM -0700, David Brownell wrote:
> On Thursday 21 August 2008, Greg Kroah-Hartman wrote:
> > + if (!class->p) {
> > + WARN(1, "%s called for class '%s' before it was initialized",
> > + __func__, class->name);
> > + return -EINVAL;
> > + }
>
> Or -- for future reference -- using WARN() with non-constant
> initial parameter:
>
> if (WARN(!class-p, "%s called ...\n" ...))
> return -EINVAL;
>
> Some of those macros now have return values, supportin C code
> that looks a bit more compact.
Ah, yeah, that looks much nicer, I'll remember that in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2008-08-21 20:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 17:30 [GIT PATCH] driver core patches against 2.6.26-rc4 Greg KH
2008-08-21 17:32 ` [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one Greg Kroah-Hartman
2008-08-22 12:41 ` Ville Syrjälä
2008-08-23 2:14 ` Greg KH
2008-08-21 17:32 ` [PATCH 02/15] Japanese translation of Documentation/SubmitChecklist Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 04/15] drivers/base/driver.c: remove unused to_dev() macro Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 05/15] dev_printk(): constify the `dev' argument Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 06/15] driver model: anti-oopsing medicine Greg Kroah-Hartman
2008-08-21 18:24 ` David Brownell
2008-08-21 20:04 ` Greg KH [this message]
2008-08-21 17:32 ` [PATCH 07/15] PM: don't skip device PM init when CONFIG_PM_SLEEP isn't set and CONFIG_PM is set Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 08/15] driver core: add init_name to struct device Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 09/15] PM: Remove WARN_ON from device_pm_add Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 10/15] block: fix partial read() of /proc/{partitions,diskstats} Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 11/15] block: drop references taken by class_find_device() Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 12/15] UIO: uio_pdrv: fix memory leak Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 13/15] UIO: uio_pdrv: fix license specification Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 14/15] UIO: generic irq handling for some uio platform devices Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 15/15] pnp: fix "add acpi:* modalias entries" Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821200441.GA18318@suse.de \
--to=gregkh@suse.de \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox