Re: [Bug 11388] New: 2.6.27-rc3 warns about MTRR range; only 3 of 16gb of memory is usable

Arjan van de Ven
2008-08-23T23:53:47Z

On Fri, 22 Aug 2008 08:24:59 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
> > > + if (tmp != mask_lo) {
> > > + WARN_ON("mtrr: your BIOS has set up an
> > > incorrect mask, fixing it up.\n");
> >
> > can you change WARN_ON to WARN_ON_ONCE ?
>
> the commit below does that. Note that the condition is
> WARN_ON(condition) or WARN(string) - WARN_ON(string) will just print
> a kernel stack unconditionally. Unfortunately there's no WARN_ONCE().
> (Arjan?)

Andrew removed that from the patches as "unused" :-(
oh well easy to add back ;-)

--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org