Re: [Bug 11388] New: 2.6.27-rc3 warns about MTRR range; only 3 of 16gb of memory is usable

Ingo Molnar
2008-08-25T09:19:26Z

* Arjan van de Ven <arjan@infradead.org> wrote:

> On Fri, 22 Aug 2008 08:24:59 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> >
> > > > + if (tmp != mask_lo) {
> > > > + WARN_ON("mtrr: your BIOS has set up an
> > > > incorrect mask, fixing it up.\n");
> > >
> > > can you change WARN_ON to WARN_ON_ONCE ?
> >
> > the commit below does that. Note that the condition is
> > WARN_ON(condition) or WARN(string) - WARN_ON(string) will just print
> > a kernel stack unconditionally. Unfortunately there's no WARN_ONCE().
> > (Arjan?)
>
> Andrew removed that from the patches as "unused" :-(
> oh well easy to add back ;-)

please send a patch, with at least one user :-)

Ingo