From: Andi Kleen <andi@firstfloor.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Dave Airlie <airlied@gmail.com>,
Rene Herman <rene.herman@keyaccess.nl>,
Ingo Molnar <mingo@elte.hu>, "Li, Shaohua" <shaohua.li@intel.com>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Arjan van de Ven <arjan@infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Jones <davej@codemonkey.org.uk>
Subject: Re: AGP and PAT (induced?) problem (on AMD family 6)
Date: Fri, 22 Aug 2008 04:12:21 +0200 [thread overview]
Message-ID: <20080822021221.GD23334@one.firstfloor.org> (raw)
In-Reply-To: <20080821211302.GD1152@linux-os.sc.intel.com>
> Andi, we are planning to add couple of page flags which will track
page flags are still scarce unfortunately, at least on 32bit.
It's a little better now than it used to be (at some point
they were nearly out before some were reclaimed), but adding a lot
of flags is still difficult.
In interest of full disclosure I need at least two for other
work too.
On 64bit adding a lot of new flags is fine, but 64bit only
solutions are not good in this case.
> the memory attribute of the page. We need to do some checks like,
> allow the memory attribute of the page to be changed, only if it is not
> mapped any where and not on free lists(like the in the X driver case,
> where they allocate the page and then change the attribute). Similarly,
> in generic -mm, we need to ensure that the page before it gets added to free
> list, has the right memory attribute etc.
You want to handle that in __free_pages?
I would have thought that should be handled in some higher level
function which could just check the memattr.
If the driver is exposing this
> page with special attribute, then it is drivers responsibility to
> use the same attribute across all the mappings.
>
> Is there a reason why this won't work with anonymous pages? Can you please
> elaborate.
The issue is just if you reuse the two list heads in struct page
because they're already used by the
Adding flags does not conflict here of course.
> > Also it doesn't fix the scalability of the data structure anyways
> > (a list is a list), just saves some memory.
>
> With this, we will track only the reserved regions using the linked list
> and typically these reserved regions will be small number (may be huge
> contiguous chunks but total number of such chunks will be reasonably smaller).
Reserved region defined how exactly?
-Andi
next prev parent reply other threads:[~2008-08-22 2:10 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 16:30 AGP and PAT (induced?) problem (on AMD family 6) Rene Herman
2008-08-06 13:51 ` Andreas Herrmann
2008-08-06 20:57 ` Rene Herman
2008-08-11 9:46 ` Rene Herman
2008-08-15 14:22 ` Ingo Molnar
2008-08-15 15:24 ` Rene Herman
2008-08-19 10:11 ` Rene Herman
2008-08-19 10:26 ` Ingo Molnar
2008-08-19 14:19 ` Rene Herman
2008-08-19 19:07 ` Venki Pallipadi
2008-08-19 19:22 ` Rene Herman
2008-08-19 23:28 ` Venki Pallipadi
2008-08-20 10:09 ` Ingo Molnar
2008-08-20 10:04 ` Ingo Molnar
2008-08-20 10:50 ` Rene Herman
2008-08-20 14:27 ` Rene Herman
2008-08-20 19:41 ` Venki Pallipadi
2008-08-20 21:40 ` Rene Herman
2008-08-20 21:46 ` Dave Airlie
2008-08-20 22:16 ` Venki Pallipadi
2008-08-21 3:42 ` Andi Kleen
2008-08-21 21:13 ` Suresh Siddha
2008-08-22 2:12 ` Andi Kleen [this message]
2008-08-21 12:06 ` Ingo Molnar
2008-08-21 17:15 ` Rene Herman
2008-08-21 22:10 ` [PATCH] x86: {reverve,free}_memtype() take a physical address Rene Herman
2008-08-21 22:16 ` Pallipadi, Venkatesh
2008-08-21 22:26 ` Rene Herman
2008-08-21 22:57 ` Pallipadi, Venkatesh
2008-08-21 23:06 ` Rene Herman
2008-08-21 23:02 ` [PATCH] x86: have set_memory_array_{uc,wb} coalesce memtypes Rene Herman
2008-08-22 4:15 ` Ingo Molnar
2008-08-22 19:08 ` Venki Pallipadi
2008-08-22 20:15 ` Rene Herman
2008-08-23 15:33 ` Ingo Molnar
2008-08-22 20:02 ` Rene Herman
2008-09-10 19:52 ` AGP PAT issue Rene Herman
2008-09-11 8:17 ` Ingo Molnar
2008-09-11 8:30 ` Rene Herman
2008-09-13 0:26 ` Pallipadi, Venkatesh
2008-09-13 0:44 ` Rene Herman
2008-10-09 15:53 ` Thomas Hellstrom
2008-10-13 17:10 ` Pallipadi, Venkatesh
2008-10-13 19:26 ` Thomas Hellström
2008-08-20 21:02 ` AGP and PAT (induced?) problem (on AMD family 6) Dave Airlie
2008-08-20 21:16 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822021221.GD23334@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=airlied@gmail.com \
--cc=andreas.herrmann3@amd.com \
--cc=arjan@infradead.org \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rene.herman@keyaccess.nl \
--cc=shaohua.li@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox