Re: [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one.

["Ville Syrjälä" <syrjala@sci.fi>]

On Thu, Aug 21, 2008 at 10:32:49AM -0700, Greg Kroah-Hartman wrote:
> From: Ingo Oeser <ioe-lkml@rameria.de>
> 
> A recent patch from Kay Sievers <kay.sievers@vrfy.org>
> replaced the first occurrence of '/' with '!' as needed for block devices.
> 
> Now do some cheap defensive coding and replace all of them to avoid future
> issues in this area.
> 
> Signed-off-by: Ingo Oeser <ioe-lkml@rameria.de>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>  lib/kobject.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/kobject.c b/lib/kobject.c
> index bd732ff..fbf0ae2 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
>  		return -ENOMEM;
>  
>  	/* ewww... some of these buggers have '/' in the name ... */
> -	s = strchr(kobj->name, '/');
> -	if (s)
> +	while ((s = strchr(kobj->name, '/')))
>  		s[0] = '!';

That's somewhat inefficient. How about this?

s = kobj->name;
while ((s = strchr(s, '/')))
	*s++ = '!';

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/