From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: Fix oops in acer_wmi
Date: Sun, 24 Aug 2008 02:19:41 +0100 [thread overview]
Message-ID: <200808240219.41946.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <20080823140509.4b197021@infradead.org>
On Saturday 23 August 2008 22:05:09 Arjan van de Ven wrote:
> this is due to a null pointer due to a misordered initialization...
> when the DMI quirks get run, the "interface" variable might not have been
> initialized. The patch below 1) prevents the oops and 2) runs the quirks
> again after all the "interface" initialization has completed.
Acked-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
(Although this patch is missing an SOB from yourself).
> This oops is new in 2.6.27-rc and thus counts as a regression...
NAK - I disagree. This has been broken since day one, there is nothing
special, as far as I am concerned, about 2.6.27 in this respect.
(If this is showing up that much in kerneloops.org, then I would recommend
CC'ing it to stable).
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2008-08-24 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 21:05 Fix oops in acer_wmi Arjan van de Ven
2008-08-24 1:19 ` Carlos Corbacho [this message]
2008-08-24 4:45 ` Arjan van de Ven
2008-08-24 8:38 ` Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808240219.41946.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox