public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: objcopy version test for local symbols
Date: Mon, 25 Aug 2008 21:01:03 +0200	[thread overview]
Message-ID: <20080825190103.GA24029@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0808251434000.23923@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> From: Steven Rostedt <srostedt@redhat.com>
> Subject: ftrace: objcopy version test for local symbols
> 
> The --globalize-symbols option came out in objcopy version 2.17.
> If the kernel is being compiled on a system with a lower version of
> objcopy, then we can not use the globalize / localize trick to
> link to symbols pointing to local functions.
> 
> This patch tests the version of objcopy and will only use the trick
> if the version is greater than or equal to 2.17. Otherwise, if an
> object has only local functions within a section, it will give a
> nice warning and recommend the user to upgrade their objcopy.
> 
> Leaving the symbols unrecorded is not that big of a deal, since the
> mcount record method changes the actual mcount code to be a simple
> "ret" without recording registers or anything.
> 
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>

applied to tip/tracing/ftrace, also have integrated it into 
auto-ftrace-next. (without much testing - i hope it goes well)

	Ingo

  reply	other threads:[~2008-08-25 19:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080825130117.33fe34bc.sfr@canb.auug.org.au>
     [not found] ` <20080825060934.GB14993@elte.hu>
2008-08-25 18:52   ` [PATCH] ftrace: objcopy version test for local symbols Steven Rostedt
2008-08-25 19:01     ` Ingo Molnar [this message]
2008-08-25 23:46       ` Stephen Rothwell
2008-08-26  1:51         ` Stephen Rothwell
2008-08-26  2:34           ` Steven Rostedt
2008-08-26  3:25           ` [PATCH] ftrace: only warn once on old objcopy and local functions Steven Rostedt
2008-08-26  5:47             ` Stephen Rothwell
2008-08-26 20:53               ` Steven Rostedt
2008-08-27 17:02               ` [PATCH] ftrace: remove warning of " Steven Rostedt
2008-08-28  7:52                 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080825190103.GA24029@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox