* Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
[not found] <20080825214454.18253.82244.stgit@tigger.helgaas>
@ 2008-08-26 1:56 ` Matthew Wilcox
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Wilcox @ 2008-08-26 1:56 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Jesse Barnes, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
David Airlie, Mauro Carvalho Chehab, Samuel Ortiz, linux-kernel
On Mon, Aug 25, 2008 at 03:44:54PM -0600, Bjorn Helgaas wrote:
> These patches change various debug messages to use "[%04x:%04x]" for
> PCI vendor/device IDs to follow the format used by lspci(8).
Entire patchset:
Acked-by: Matthew Wilcox <willy@linux.intel.com>
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
@ 2008-08-25 22:01 Bjorn Helgaas
2008-08-25 22:05 ` Arjan van de Ven
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2008-08-25 22:01 UTC (permalink / raw)
To: linux-kernel
These patches change various debug messages to use "[%04x:%04x]" for
PCI vendor/device IDs to follow the format used by lspci(8).
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
2008-08-25 22:01 Bjorn Helgaas
@ 2008-08-25 22:05 ` Arjan van de Ven
2008-08-25 22:15 ` Bjorn Helgaas
2008-08-25 23:53 ` Alexey Dobriyan
0 siblings, 2 replies; 6+ messages in thread
From: Arjan van de Ven @ 2008-08-25 22:05 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-kernel
On Mon, 25 Aug 2008 16:01:38 -0600
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> These patches change various debug messages to use "[%04x:%04x]" for
> PCI vendor/device IDs to follow the format used by lspci(8).
I hope you're adding a new whicked special format specifier for this
... taking a PCI dev struct as argument.
That's be really nice to have;-)
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
2008-08-25 22:05 ` Arjan van de Ven
@ 2008-08-25 22:15 ` Bjorn Helgaas
2008-08-25 23:53 ` Alexey Dobriyan
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2008-08-25 22:15 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel
On Monday 25 August 2008 04:05:25 pm Arjan van de Ven wrote:
> On Mon, 25 Aug 2008 16:01:38 -0600
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> > These patches change various debug messages to use "[%04x:%04x]" for
> > PCI vendor/device IDs to follow the format used by lspci(8).
>
> I hope you're adding a new whicked special format specifier for this
> ... taking a PCI dev struct as argument.
>
> That's be really nice to have;-)
Huh, that's kind of a cool idea. The %p<x> namespace is unlimited,
right? If it were only a single character specifier, this one doesn't
seem common enough to eat 1/26 of the space.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
2008-08-25 22:05 ` Arjan van de Ven
2008-08-25 22:15 ` Bjorn Helgaas
@ 2008-08-25 23:53 ` Alexey Dobriyan
2008-08-26 16:55 ` Bjorn Helgaas
1 sibling, 1 reply; 6+ messages in thread
From: Alexey Dobriyan @ 2008-08-25 23:53 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Bjorn Helgaas, linux-kernel
On Mon, Aug 25, 2008 at 03:05:25PM -0700, Arjan van de Ven wrote:
> On Mon, 25 Aug 2008 16:01:38 -0600
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> > These patches change various debug messages to use "[%04x:%04x]" for
> > PCI vendor/device IDs to follow the format used by lspci(8).
>
> I hope you're adding a new whicked special format specifier for this
> ... taking a PCI dev struct as argument.
>
> That's be really nice to have;-)
You should sign Treaty of the Non-Proliferation of Format Specifiers.
Untill too late...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device
2008-08-25 23:53 ` Alexey Dobriyan
@ 2008-08-26 16:55 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2008-08-26 16:55 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Arjan van de Ven, linux-kernel
On Monday 25 August 2008 05:53:13 pm Alexey Dobriyan wrote:
> On Mon, Aug 25, 2008 at 03:05:25PM -0700, Arjan van de Ven wrote:
> > On Mon, 25 Aug 2008 16:01:38 -0600
> > Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> >
> > > These patches change various debug messages to use "[%04x:%04x]" for
> > > PCI vendor/device IDs to follow the format used by lspci(8).
> >
> > I hope you're adding a new whicked special format specifier for this
> > ... taking a PCI dev struct as argument.
> >
> > That's be really nice to have;-)
>
> You should sign Treaty of the Non-Proliferation of Format Specifiers.
>
> Untill too late...
OK. I'll wait with any new format specifiers for now. Relative to
something like printing resources, where a new format specifier could
help get rid of a ton of ugly casts, this PCI vendor/device stuff
is pretty minor.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-08-26 16:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080825214454.18253.82244.stgit@tigger.helgaas>
2008-08-26 1:56 ` [PATCH 0/5] use lspci style for [%04x:%04x] vendor/device Matthew Wilcox
2008-08-25 22:01 Bjorn Helgaas
2008-08-25 22:05 ` Arjan van de Ven
2008-08-25 22:15 ` Bjorn Helgaas
2008-08-25 23:53 ` Alexey Dobriyan
2008-08-26 16:55 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox