From: Pavel Machek <pavel@suse.cz>
To: Avi Kivity <avi@qumranet.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] x86: default to reboot via ACPI
Date: Tue, 26 Aug 2008 11:50:32 +0200 [thread overview]
Message-ID: <20080826095032.GA309@elf.ucw.cz> (raw)
In-Reply-To: <1219659087-17536-1-git-send-email-avi@qumranet.com>
On Mon 2008-08-25 13:11:27, Avi Kivity wrote:
> Triple-fault and keyboard reset may assert INIT instead of RESET; however
> INIT is blocked when Intel VT is enabled. This leads to a partially reset
> machine when invoking emergency_restart via sysrq-b: the processor is still
> working but other parts of the system are dead.
>
> Default to rebooting via ACPI, which correctly asserts RESET and reboots the
> machine.
>
> This is safe since we will fall back to keyboard reset and triple fault if
> acpi is not enabled or if the reset is not successful.
>
> Signed-off-by: Avi Kivity <avi@qumranet.com>
"ACPI" and "safe" in one sentence. /me bets this will break lot of
machines.
What about only doing that when enabling VT?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-08-26 9:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 10:11 [PATCH] x86: default to reboot via ACPI Avi Kivity
2008-08-25 10:32 ` Ingo Molnar
2008-08-26 9:50 ` Pavel Machek [this message]
2008-08-26 10:05 ` Avi Kivity
2008-08-26 10:33 ` Alan Cox
2008-08-26 12:14 ` Avi Kivity
2008-08-26 12:31 ` Andi Kleen
2008-08-26 13:24 ` Maciej W. Rozycki
2008-08-26 13:33 ` Avi Kivity
2008-08-26 14:12 ` Pavel Machek
2008-08-26 14:50 ` Maciej W. Rozycki
2008-08-26 14:24 ` Maciej W. Rozycki
2008-08-26 16:10 ` Alan Cox
2008-08-26 16:16 ` Andi Kleen
2008-08-27 9:18 ` Pavel Machek
2008-08-27 10:51 ` Avi Kivity
2008-08-27 13:13 ` Pavel Machek
2008-08-26 11:03 ` Frans Meulenbroeks
2008-08-26 10:52 ` Alan Cox
2008-08-26 11:07 ` Ingo Molnar
2008-08-26 10:36 ` Ingo Molnar
2008-08-26 11:26 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826095032.GA309@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=avi@qumranet.com \
--cc=ebiederm@xmission.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox