From: Matthew Wilcox <matthew@wil.cx>
To: Daniel Walker <dwalker@mvista.com>
Cc: Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Len Brown <len.brown@intel.com>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] acpi: semaphore removal
Date: Tue, 26 Aug 2008 13:50:51 -0600 [thread overview]
Message-ID: <20080826195051.GF23698@parisc-linux.org> (raw)
In-Reply-To: <1219779046.3797.12.camel@dhcp32.mvista.com>
On Tue, Aug 26, 2008 at 12:30:46PM -0700, Daniel Walker wrote:
> On Tue, 2008-08-26 at 13:13 -0600, Matthew Wilcox wrote:
> > On Tue, Aug 26, 2008 at 11:59:49AM -0700, Daniel Walker wrote:
> > > The semaphore usage in ACPI is more like completions. The ASL
> >
> > Huh? They are semaphores. They're not 'more like completions' at all.
>
> You can clearly make a completion out of a semaphore, but we have a
> completion API .. ACPI is using locked semaphores, and essentially
> re-making completions with the semaphore API..
What makes you think that?
executer/excreate.c: status = acpi_os_create_semaphore(ACPI_NO_UNIT_LIMIT, 0,
executer/exsystem.c: acpi_os_create_semaphore(ACPI_NO_UNIT_LIMIT, 0, &temp_semaphore);
namespace/nsaccess.c: acpi_os_create_semaphore(1, 0,
osl.c:acpi_os_create_semaphore(u32 max_units, u32 initial_units, acpi_handle * handle)
All users set 'initial_units' to 0.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-08-26 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 18:59 [PATCH 1/4] mutex: add mutex_lock_timeout() Daniel Walker
2008-08-26 18:59 ` [PATCH 2/4] acpi: add real mutex function calls Daniel Walker
2008-08-26 18:59 ` [PATCH 3/4] acpi: add lockdep magic Daniel Walker
2008-08-26 18:59 ` [PATCH 4/4] acpi: semaphore removal Daniel Walker
2008-08-26 19:13 ` Matthew Wilcox
2008-08-26 19:30 ` Daniel Walker
2008-08-26 19:50 ` Matthew Wilcox [this message]
2008-08-26 20:03 ` Daniel Walker
2008-08-26 19:32 ` [PATCH 1/4] mutex: add mutex_lock_timeout() Andi Kleen
2008-08-26 19:51 ` Daniel Walker
2008-08-26 21:13 ` Andi Kleen
2008-08-26 22:09 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826195051.GF23698@parisc-linux.org \
--to=matthew@wil.cx \
--cc=ak@linux.intel.com \
--cc=dwalker@mvista.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.moore@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox