From: sukadev@us.ibm.com
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Emelyanov <xemul@openvz.org>,
Robert Rex <robert.rex@exasol.com>,
Roland McGrath <roland@redhat.com>,
Serge Hallyn <serue@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] pid_ns: (BUG 11391) change ->child_reaper when init->group_leader exits
Date: Tue, 26 Aug 2008 16:33:53 -0700 [thread overview]
Message-ID: <20080826233353.GA21052@us.ibm.com> (raw)
In-Reply-To: <20080824154912.GA3780@tv-sign.ru>
I was able to repro the problem without the patchset and could not
reproduce with the patchset. But just had a quick question while
reviewing the patches.
Oleg Nesterov [oleg@tv-sign.ru] wrote:
| We don't change pid_ns->child_reaper when the main thread of the
| subnamespace init exits. As Robert Rex <robert.rex@exasol.com>
| pointed out this is wrong.
|
| Yes, the re-parenting itself works correctly, but if the reparented
| task exits it needs ->parent->nsproxy->pid_ns in do_notify_parent(),
If the task was reparented, then with patch 1/4 its parent would be
the global init (init_pid_ns.child_reaper) right ?
| and if the main thread is zombie its ->nsproxy was already cleared
| by exit_task_namespaces().
If above is true, then even if the main thread's nsproxy is NULL, does
it affect the reparented task ?
next prev parent reply other threads:[~2008-08-26 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 15:49 [PATCH 2/4] pid_ns: (BUG 11391) change ->child_reaper when init->group_leader exits Oleg Nesterov
2008-08-26 23:33 ` sukadev [this message]
2008-08-27 0:35 ` sukadev
2008-08-27 17:06 ` Oleg Nesterov
2008-08-27 2:24 ` Serge E. Hallyn
2008-08-27 11:38 ` Pavel Emelyanov
2008-08-27 18:04 ` sukadev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826233353.GA21052@us.ibm.com \
--to=sukadev@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=robert.rex@exasol.com \
--cc=roland@redhat.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox