Re: [PATCH] USB: add USB test and measurement class driver

Oliver Neukum
2008-08-27T08:55:33Z

Am Mittwoch 27 August 2008 02:05:01 schrieb Greg KH:

> I've now added this to my tree, and any review comments are greatly
> welcome.

Unfortunately the issues are not trivial.

1. USBTMC_SIZE_IOBUFFER
use 2048. 4096 means a multipage allocation

2. usbtmc_open race with disconnect
already mailed about

3. read/write and, if you convert to unlocked_ioctl, need protection
against reentry

4. read, write & ioctl need protection against using a rebound interface
you add a mutex, that you need for (3) anyway to the descriptor and protected
by this mutex you set the interface and device pointers to null in disconnect
and check them in the affected methods

5.get_capabilities
kmalloced buffer is never freed

6. disconnect fails to remove sysfs attributes

7. probe will report success even if usb_register_dev fails

Regards
Oliver