From: Ingo Molnar <mingo@elte.hu>
To: Zhu Yi <yi.zhu@intel.com>
Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: fix invalid list_del_rcu in zap_class
Date: Wed, 27 Aug 2008 08:41:39 +0200 [thread overview]
Message-ID: <20080827064139.GD6255@elte.hu> (raw)
In-Reply-To: <20080827063300.GA18265@mail.intel.com>
* Zhu Yi <yi.zhu@intel.com> wrote:
> BUG: unable to handle kernel NULL pointer dereference at
> 0000000000000008
> IP: [<ffffffff810531e1>] zap_class+0x24/0x82
> The root cause for this oops is in add_lock_to_list() when
> save_trace() fails due to MAX_STACK_TRACE_ENTRIES is reached,
> entry->class is assigned but entry is never added into any lock list.
> This makes the list_del_rcu() in zap_class() oops later when the
> module is unloaded. This patch fixes the problem by assigning
> entry->class after save_trace() returns success.
good spotting! Applied to tip/core/urgent, thanks.
Ingo
prev parent reply other threads:[~2008-08-27 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 6:33 [PATCH] lockdep: fix invalid list_del_rcu in zap_class Zhu Yi
2008-08-27 6:41 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827064139.GD6255@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox