public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Korty <joe.korty@ccur.com>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Jeff Garzik <jgarzik@redhat.com>,
	Tobias Diedrich <ranma+kernel@tdiedrich.de>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [ETH] forcdeth: increase max_interrupt_work
Date: Wed, 27 Aug 2008 10:21:36 -0400	[thread overview]
Message-ID: <20080827142136.GA22262@tsunami.ccur.com> (raw)

Forcedeth: increase max_interrupt_work

This eliminates the following often-generated warning from
my 64 bit Opteron SMP test stand:

	eth0: too many iterations (6) in nv_nic_irq

According to the web, the problem is that the forcedeth
driver has a too-low value for max_interrupt_work.
Grepping the kernel I see that forcedeth has the second
lowest value of all ethernet drivers (ie, 6).  Most are
in the 20-40 range.  So this patch increases this a bit,
from 6 to 15 (at 15 forcedeth becomes the driver with
third-lowest max_interrupt_work value).

My test stand, which used to print out the above warnings
repetitively whenever it was under heavy net load, no
longer does so.

Signed-off-by: Joe Korty <joe.korty@ccur.com>

Index: 2.6.27-rc4-git4/drivers/net/forcedeth.c
===================================================================
--- 2.6.27-rc4-git4.orig/drivers/net/forcedeth.c	2008-08-27 09:49:13.000000000 -0400
+++ 2.6.27-rc4-git4/drivers/net/forcedeth.c	2008-08-27 10:02:40.000000000 -0400
@@ -818,7 +818,7 @@
  * Maximum number of loops until we assume that a bit in the irq mask
  * is stuck. Overridable with module param.
  */
-static int max_interrupt_work = 5;
+static int max_interrupt_work = 15;
 
 /*
  * Optimization can be either throuput mode or cpu mode

             reply	other threads:[~2008-08-27 14:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 14:21 Joe Korty [this message]
2008-08-31  8:48 ` [ETH] forcdeth: increase max_interrupt_work Tobias Diedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827142136.GA22262@tsunami.ccur.com \
    --to=joe.korty@ccur.com \
    --cc=aabdulla@nvidia.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ranma+kernel@tdiedrich.de \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox