The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Roland McGrath <roland@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] utrace core
Date: Thu, 28 Aug 2008 00:04:13 +0400	[thread overview]
Message-ID: <20080827200413.GA31324@x200.localdomain> (raw)
In-Reply-To: <20080826220157.397C7154233@magilla.localdomain>

1. UTRACE_ATTACH_MATCH_DATA is not used.

2. s/utrace_attached_engine/utrace_engine/g

   Engine which is not attached is either just allocated or scheduled
   for freeing

3. get_utrace_lock() is funny.

   From name one should get valid struct utrace or -E depending only on
   task, why engine matters is a mystery.

4. subsys_initcall

   Just use module_init() or comment why it's needed.

5. Dummy in examiner -- not used (of course!)


  parent reply	other threads:[~2008-08-27 20:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 22:01 [PATCH 0/2] utrace Roland McGrath
2008-08-26 22:01 ` [PATCH 1/2] utrace core Roland McGrath
2008-08-26 22:55   ` Alexey Dobriyan
2008-08-27 21:32     ` Alexey Dobriyan
2008-08-27 21:46       ` Alexey Dobriyan
2008-08-27 22:00         ` Alexey Dobriyan
2008-08-30 13:45     ` Christoph Hellwig
2008-09-03 12:11     ` Roland McGrath
2008-09-03 17:01       ` Alexey Dobriyan
2008-08-27 20:04   ` Alexey Dobriyan [this message]
2008-09-03 12:11     ` Roland McGrath
2008-09-03 18:44       ` Christoph Hellwig
2008-08-30 15:05   ` Alexey Dobriyan
2008-09-03 12:58   ` Petr Tesarik
2008-09-03 18:08     ` Roland McGrath
2008-09-03 18:46       ` Christoph Hellwig
2008-09-04  9:03         ` Petr Tesarik
2008-08-26 22:02 ` [PATCH 2/2] utrace: ptrace cooperation Roland McGrath
2008-08-30 13:38   ` Christoph Hellwig
2008-09-03 12:10     ` Roland McGrath
2008-09-03 18:41       ` Christoph Hellwig
2008-08-26 22:34 ` [PATCH 0/2] utrace Alexey Dobriyan
2008-08-26 22:39   ` Christoph Hellwig
2008-08-27  0:17   ` Frank Ch. Eigler
2008-08-27 13:54     ` Christoph Hellwig
2008-08-27 16:40       ` Ananth N Mavinakayanahalli
2008-08-30 13:40         ` Christoph Hellwig
2008-09-03 12:09           ` Roland McGrath
2008-09-03 18:37             ` Christoph Hellwig
2008-08-27 15:34     ` Alexey Dobriyan
2008-08-29 19:04       ` Frank Ch. Eigler
2008-08-30 13:43       ` Christoph Hellwig
2008-08-27 18:50   ` Alexey Dobriyan
2008-08-27  2:03 ` Peter Zijlstra
2008-10-06 20:47 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827200413.GA31324@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox