From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com,
linux-ext4@vger.kernel.org, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -V3 01/11] percpu_counters: make fbc->count read atomic on 32 bit architecture
Date: Wed, 27 Aug 2008 21:06:52 -0700 [thread overview]
Message-ID: <20080827210652.dcbe5ff4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080828034816.GA6440@skywalker>
On Thu, 28 Aug 2008 09:18:16 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > This is now too large to be inlined.
> >
>
>
> How do we actually figure that out ? I have been making that mistakes
> quiet often.
Well. Experience and guesswork, mainly.
But a useful metric is to look and the /bin/size output before and
after the inlining. In this case fs/ext3/ialloc.o's text shrunk 40-odd
bytes, which we think is a net benefit due to reduced CPU cache
pressure.
next prev parent reply other threads:[~2008-08-28 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 15:28 [PATCH -V3 01/11] percpu_counters: make fbc->count read atomic on 32 bit architecture Aneesh Kumar K.V
2008-08-27 19:05 ` Andrew Morton
2008-08-27 21:01 ` Peter Zijlstra
2008-08-27 21:22 ` Andrew Morton
2008-08-28 3:52 ` Aneesh Kumar K.V
2008-08-28 4:09 ` Andrew Morton
2008-08-28 22:59 ` Mingming Cao
2008-08-28 7:57 ` Peter Zijlstra
2008-08-28 3:48 ` Aneesh Kumar K.V
2008-08-28 4:06 ` Andrew Morton [this message]
2008-08-28 14:19 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827210652.dcbe5ff4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox