From: Andy Whitcroft <apw@shadowen.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] checkpatch: complex macros need to ignore comments
Date: Thu, 28 Aug 2008 16:17:44 +0100 [thread overview]
Message-ID: <20080828151744.GD27763@brain> (raw)
In-Reply-To: <alpine.LNX.1.10.0807052043210.28765@fbirervta.pbzchgretzou.qr>
On Sat, Jul 05, 2008 at 08:44:35PM +0200, Jan Engelhardt wrote:
>
> On Wednesday 2008-07-02 13:31, Andy Whitcroft wrote:
>
> >Ensure we ignore comments in complex macro detection else we incorrectly
> >report this:
> >
> > #define PFM_GROUP_PERM_ANY -1 /* any user/group */
>
> Does it also catch this ugly piece from dcache.c?
>
>
> #define DCACHE_NFSFS_RENAMED 0x0002 /* this dentry has been "silly
> * renamed" and has to be
> * deleted on the last dput()
> */
Yeah it should indeed. A quick check with the current version seems to
confirm that.
-apw
next prev parent reply other threads:[~2008-08-28 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 11:31 [PATCH 0/5] update checkpatch to version 0.21 Andy Whitcroft
2008-07-02 11:31 ` [PATCH 1/5] checkpatch: add checks for question mark and colon spacing Andy Whitcroft
2008-07-02 11:31 ` [PATCH 2/5] checkpatch: variants -- move the main unary/binary operators to use variants Andy Whitcroft
2008-07-02 11:31 ` [PATCH 3/5] checkpatch: complex macros need to ignore comments Andy Whitcroft
2008-07-05 18:44 ` Jan Engelhardt
2008-08-28 15:17 ` Andy Whitcroft [this message]
2008-07-02 11:31 ` [PATCH 4/5] checkpatch: types cannot start mid word for pointer tests Andy Whitcroft
2008-07-02 11:31 ` [PATCH 5/5] checkpatch: version 0.21 Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828151744.GD27763@brain \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=jengelh@medozas.de \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox