From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] resource/x86: add sticky resource type
Date: Thu, 28 Aug 2008 22:17:58 +0200 [thread overview]
Message-ID: <20080828201758.GA18437@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0808281015440.3300@nehalem.linux-foundation.org>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> The fact is, the only reliable way to handle these things has _always_
> been to ask the hardware first. Add the broken resources from ACPI and
> other BIOS tables _later_. If they conflict, it is the ACPI/BIOS
> tables that should be removed.
i fully agree with that principle, i just messed up implementing it.
'Sticky resources' tried to be exactly the kind of 'untrusted, possibly
wrong' resources, which should not prevent existing PCI resources from
being registered - they would at most prevent new PCI resources from
being allocated over them. (the free space is large enough for us to
take the small/untrusted hint from the BIOS where not to allocate to)
I missed the possibility of a sticky resource not being wide enough and
preventing a BAR from being registered, due to partial overlap. That was
not intended.
I guess this whole patchset has to become a lot wider and a lot more
involved.
Ingo
prev parent reply other threads:[~2008-08-28 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 1:56 [PATCH] resource/x86: add sticky resource type Yinghai Lu
2008-08-28 8:21 ` Ingo Molnar
2008-08-28 17:20 ` Linus Torvalds
2008-08-28 20:17 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828201758.GA18437@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox