From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86: early_printk.c trivial sparse fixes
Date: Thu, 28 Aug 2008 22:19:16 -0700 [thread overview]
Message-ID: <20080828221916.eca064ae.akpm@linux-foundation.org> (raw)
In-Reply-To: <1219103789.17033.0.camel@brick>
On Mon, 18 Aug 2008 16:56:29 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -989,7 +989,7 @@ static int __init setup_early_printk(char *buf)
> return 0;
> }
>
> -void __init enable_debug_console(char *buf)
> +static void __init enable_debug_console(char *buf)
> {
> #ifdef DBGP_DEBUG
> struct console *old_early_console = NULL;
umm,
arch/x86/kernel/early_printk.c:993: warning: 'enable_debug_console' defined but not used
enable_debug_console() never has been used afaict. If it was supposed
to be a __setup function then it'll need documentation in
Documentation/kernel-parameters.txt too, please.
prev parent reply other threads:[~2008-08-29 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 23:56 [PATCH] x86: early_printk.c trivial sparse fixes Harvey Harrison
2008-08-19 0:14 ` Ingo Molnar
2008-08-29 5:19 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828221916.eca064ae.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox