Re: [PATCH] x86: early_printk.c trivial sparse fixes

Andrew Morton
2008-08-29T05:19:44Z

On Mon, 18 Aug 2008 16:56:29 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:

> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -989,7 +989,7 @@ static int __init setup_early_printk(char *buf)
> return 0;
> }
>
> -void __init enable_debug_console(char *buf)
> +static void __init enable_debug_console(char *buf)
> {
> #ifdef DBGP_DEBUG
> struct console *old_early_console = NULL;

umm,

arch/x86/kernel/early_printk.c:993: warning: 'enable_debug_console' defined but not used

enable_debug_console() never has been used afaict. If it was supposed
to be a __setup function then it'll need documentation in
Documentation/kernel-parameters.txt too, please.