From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org,
Stefani Seibold <stefani@seibold.net>,
Dario Faggioli <raistlin@linux.it>,
Max Krasnyansky <maxk@qualcomm.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 6/6] sched: disabled rt-bandwidth by default
Date: Thu, 28 Aug 2008 23:45:16 +1000 [thread overview]
Message-ID: <200808282345.16564.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080828130708.GA19672@elte.hu>
On Thursday 28 August 2008 23:07, Ingo Molnar wrote:
> * Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > There is no customer issue and there is no handwaving about
> > compliance;
>
> well, the reason i'm asking is that i cannot for anything in the world
> imagine you being so upset about _anything_ but something that involves
> benchmark runs ;-)
;) Well yes as you know I'm not actively doing much scheduler work for
a while now. Luckily there are a lot of really good people who probably
do a better job on it than me anyway, so on the whole I'm quite happy
with it.
But ironically that's also why I hadn't raised my concerns earlier... I
simply was not aware of the change. So I wish I had participated in the
discussion earlier, but that's life, so I have to raise my concern now.
> And what does SCHED_FIFO RT policy scheduling have to do with
> performance and benchmarks? Nothing usually in the real world, except
> for this little known fact: a common 'tuning' for TPC database
> benchmarks is to run all DB threads as SCHED_FIFO to squeeze the last
> 0.1% of performance out of the setup.
>
> So - and i'm taking an educated guess here - is SCHED_FIFO+TPC
> performance perhaps one of the factors that played a role in you
> initiating this thread? If yes then it's obviously an incredibly broken
> use of SCHED_FIFO and we can add the sysctl tuning to the long list of
> dozens of other tunings that happen before a TPC run anyway.
>
> Hm?
To address this concern: no, it is not tpc ;) Actually I don't know a
thing about how tpc except what scant information can basically be
gained on the list (disclaimer: I probably could find out more under
NDA, but I don't care to).
No, there is no customer behind the scenes and nor do I have a use
case myself. I really would have told you about it by now.
I'm concerned because I honestly think there is a risk of breaking
systems. I also think that in this problem space, people often care
about guard bands and worst case scenarios so even if the app does
not do a cpu hogging polling loop or cooperative scheduling or
anything like that, then I think it is risky to add this source of
uncertianty.
The other issue is that the old behaviour (and, dare I say it,
specification) is quite straightforward. At least it is simpler and thus
I guess easier to analyze than this behaviour with the added caveat.
I realise that as Linux gets better at this, people are wanting to use
-rt programs like audio mixing on their desktops and for that kind of
thing, throttling is probably often the desired behaviour. So I can
see why it was implemented. I just think it is a nasty surprise to
have this behaviour by default in the kernel.
I hope I explained myself better now. I was not being too constructive
when I was getting heated.
What I would like to see is maybe a new SCHED_ policy or two which can
be defined basically as rt-with-throttle which some apps could use. I
also think the sysctl to throttle it is a fine idea. And for desktop
installations there is probably a much stronger argument for it. But I
disagree with having it default from kernel.org like this.
next prev parent reply other threads:[~2008-08-28 13:45 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 10:33 [PATCH 0/6] sched: rt-bandwidth fixes Peter Zijlstra
2008-08-19 10:33 ` [PATCH 1/6] sched: rt-bandwidth for user grouping interface Peter Zijlstra
2008-08-19 10:33 ` [PATCH 2/6] sched: rt-bandwidth accounting fix Peter Zijlstra
2008-08-19 18:33 ` Max Krasnyansky
2008-08-19 18:38 ` Peter Zijlstra
2008-08-19 10:33 ` [PATCH 3/6] sched: rt-bandwidth group disable fixes Peter Zijlstra
2008-08-19 10:33 ` [PATCH 4/6] sched: extract walk_tg_tree() Peter Zijlstra
2008-08-19 10:33 ` [PATCH 5/6] sched: rt-bandwidth fixes Peter Zijlstra
2008-08-19 10:33 ` [PATCH 6/6] sched: disabled rt-bandwidth by default Peter Zijlstra
2008-08-19 11:05 ` Ingo Molnar
2008-08-19 11:11 ` Ingo Molnar
2008-08-19 11:42 ` [PATCH] sched: extract walk_tg_tree(), fix Ingo Molnar
2008-08-19 11:17 ` [PATCH 6/6] sched: disabled rt-bandwidth by default Nick Piggin
2008-08-19 12:59 ` Ingo Molnar
2008-08-19 18:15 ` Max Krasnyansky
2008-08-20 11:56 ` Nick Piggin
2008-08-26 9:00 ` Nick Piggin
2008-08-26 9:30 ` Ingo Molnar
2008-08-26 9:44 ` Nick Piggin
2008-08-26 10:29 ` Ingo Molnar
2008-08-26 11:03 ` Nick Piggin
2008-08-26 9:54 ` Nick Piggin
2008-08-26 11:09 ` Thomas Gleixner
2008-08-26 11:27 ` Nick Piggin
2008-08-26 12:50 ` Theodore Tso
2008-08-26 13:31 ` Stefani Seibold
2008-08-26 17:55 ` Theodore Tso
2008-08-26 21:37 ` Thomas Gleixner
2008-08-26 22:49 ` Andi Kleen
2008-08-27 10:08 ` Nick Piggin
2008-08-28 10:54 ` Ingo Molnar
2008-08-28 11:09 ` Andi Kleen
2008-08-28 11:19 ` Peter Zijlstra
2008-08-28 11:28 ` Ingo Molnar
2008-08-28 11:50 ` Andi Kleen
2008-08-28 12:00 ` Peter Zijlstra
2008-08-28 12:14 ` Andi Kleen
2008-08-28 12:18 ` Nick Piggin
2008-08-28 16:19 ` Max Krasnyansky
2008-08-28 16:25 ` Ingo Molnar
2008-08-28 16:33 ` Andi Kleen
2008-08-28 12:03 ` Nick Piggin
2008-08-28 13:07 ` Ingo Molnar
2008-08-28 13:45 ` Nick Piggin [this message]
2008-08-28 12:29 ` Nick Piggin
2008-08-27 10:04 ` Nick Piggin
2008-08-26 13:47 ` Mark Hounschell
2008-08-26 23:00 ` Steven Rostedt
2008-08-27 18:55 ` Chris Friesen
2008-08-28 14:15 ` Steven Rostedt
2008-08-28 14:30 ` Ingo Molnar
2008-08-28 14:36 ` Nick Piggin
2008-08-28 15:12 ` Steven Rostedt
2008-08-28 15:34 ` Nick Piggin
2008-08-28 15:50 ` Steven Rostedt
2008-08-28 17:26 ` Linus Torvalds
2008-08-28 18:04 ` Steven Rostedt
2008-08-28 18:10 ` Darren Hart
2008-08-28 18:16 ` Mark Hounschell
2008-08-28 18:42 ` Linus Torvalds
2008-08-28 18:53 ` Steven Rostedt
2008-08-29 7:56 ` Mike Galbraith
2008-08-29 8:06 ` Peter Zijlstra
2008-08-29 8:47 ` Mike Galbraith
2008-08-28 19:39 ` Stefani Seibold
2008-08-28 20:53 ` Alan Cox
2008-08-30 6:33 ` Nick Piggin
2008-08-28 16:33 ` Max Krasnyansky
2008-08-28 17:22 ` John Kacur
2008-08-28 16:05 ` Peter Zijlstra
2008-08-28 16:15 ` Steven Rostedt
2008-08-28 16:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808282345.16564.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=raistlin@linux.it \
--cc=stefani@seibold.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox